public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvchange.c Date: Sat, 06 Jun 2009 22:00:00 -0000 [thread overview] Message-ID: <20090606220020.21844.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-06-06 22:00:20 Modified files: . : WHATS_NEW tools : lvchange.c Log message: Round readahead more inteligently and print warning. Round readahead at least to one page up. Print warning instead of verbose message. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1142&r2=1.1143 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.103&r2=1.104 --- LVM2/WHATS_NEW 2009/06/05 20:00:52 1.1142 +++ LVM2/WHATS_NEW 2009/06/06 22:00:20 1.1143 @@ -1,5 +1,6 @@ Version 2.02.48 - =============================== + Round up requested readahead to at least one page and print warning. Try to repair vg before actual vgremove when force flag provided. Fix possible double release of VG after recovery. Add parameter to process_each_vg specifying what to do with inconsistent VG. --- LVM2/tools/lvchange.c 2009/06/01 14:43:28 1.103 +++ LVM2/tools/lvchange.c 2009/06/06 22:00:20 1.104 @@ -370,9 +370,12 @@ if (read_ahead != DM_READ_AHEAD_AUTO && read_ahead != DM_READ_AHEAD_NONE && read_ahead % pagesize) { - read_ahead = (read_ahead / pagesize) * pagesize; - log_verbose("Rounding down readahead to %u sectors, a multiple " - "of page size %u.", read_ahead, pagesize); + if (read_ahead < pagesize) + read_ahead = pagesize; + else + read_ahead = (read_ahead / pagesize) * pagesize; + log_warn("WARNING: Overriding readahead to %u sectors, a multiple " + "of %uK page size.", read_ahead, pagesize >> 1); } if (lv->read_ahead == read_ahead) {
next reply other threads:[~2009-06-06 22:00 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-06-06 22:00 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-11-18 19:22 zkabelac 2011-09-05 12:54 agk 2009-08-13 14:27 mornfall 2008-07-31 13:03 agk 2008-05-21 14:10 agk 2008-01-26 0:13 agk 2006-10-13 21:33 agk 2006-07-10 19:39 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090606220020.21844.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).