public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvchange.c Date: Thu, 31 Jul 2008 13:03:00 -0000 [thread overview] Message-ID: <20080731130302.4228.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2008-07-31 13:03:02 Modified files: . : WHATS_NEW tools : lvchange.c Log message: Change lvchange exit status to indicate if any part of the operation failed. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.939&r2=1.940 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.92&r2=1.93 --- LVM2/WHATS_NEW 2008/07/31 12:38:31 1.939 +++ LVM2/WHATS_NEW 2008/07/31 13:03:01 1.940 @@ -1,5 +1,6 @@ Version 2.02.40 - ================================ + Change lvchange exit status to indicate if any part of the operation failed. Fix pvchange and pvremove to handle PVs without mdas. Refactor _text_pv_read and always return mda list if requested. Fix configure to work w/o readline unless --enable-readline used. (2.02.39) --- LVM2/tools/lvchange.c 2008/06/18 11:32:14 1.92 +++ LVM2/tools/lvchange.c 2008/07/31 13:03:01 1.93 @@ -545,7 +545,7 @@ static int lvchange_single(struct cmd_context *cmd, struct logical_volume *lv, void *handle __attribute((unused))) { - int doit = 0; + int doit = 0, docmds = 0; int archived = 0; if (!(lv->vg->status & LVM_WRITE) && @@ -606,6 +606,7 @@ return ECMD_FAILED; archived = 1; doit += lvchange_permission(cmd, lv); + docmds++; } /* allocation policy change */ @@ -614,6 +615,7 @@ return ECMD_FAILED; archived = 1; doit += lvchange_alloc(cmd, lv); + docmds++; } /* read ahead sector change */ @@ -622,6 +624,7 @@ return ECMD_FAILED; archived = 1; doit += lvchange_readahead(cmd, lv); + docmds++; } /* read ahead sector change */ @@ -630,6 +633,7 @@ return ECMD_FAILED; archived = 1; doit += lvchange_persistent(cmd, lv); + docmds++; if (sigint_caught()) return ECMD_FAILED; } @@ -640,6 +644,7 @@ return ECMD_FAILED; archived = 1; doit += lvchange_tag(cmd, lv, addtag_ARG); + docmds++; } /* del tag */ @@ -648,6 +653,7 @@ return ECMD_FAILED; archived = 1; doit += lvchange_tag(cmd, lv, deltag_ARG); + docmds++; } if (doit) @@ -674,6 +680,9 @@ return ECMD_FAILED; } + if (doit != docmds) + return ECMD_FAILED; + return ECMD_PROCESSED; }
next reply other threads:[~2008-07-31 13:03 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-07-31 13:03 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-11-18 19:22 zkabelac 2011-09-05 12:54 agk 2009-08-13 14:27 mornfall 2009-06-06 22:00 mbroz 2008-05-21 14:10 agk 2008-01-26 0:13 agk 2006-10-13 21:33 agk 2006-07-10 19:39 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080731130302.4228.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).