public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools vgsplit.c Date: Fri, 29 Feb 2008 00:13:00 -0000 [thread overview] Message-ID: <20080229001348.5326.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2008-02-29 00:13:48 Modified files: tools : vgsplit.c Log message: Refactor _move_pv() in vgsplit. Should be no functional change. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.50&r2=1.51 --- LVM2/tools/vgsplit.c 2008/01/30 14:00:02 1.50 +++ LVM2/tools/vgsplit.c 2008/02/29 00:13:48 1.51 @@ -15,18 +15,11 @@ #include "tools.h" -static int _move_pv(struct volume_group *vg_from, struct volume_group *vg_to, - char *pv_name) +static void _move_pv(struct volume_group *vg_from, struct volume_group *vg_to, + struct pv_list *pvl) { - struct pv_list *pvl; struct physical_volume *pv; - if (!(pvl = find_pv_in_vg(vg_from, pv_name))) { - log_error("Physical volume %s not in volume group %s", - pv_name, vg_from->name); - return 0; - } - list_del(&pvl->list); list_add(&vg_to->pvs, &pvl->list); @@ -40,8 +33,6 @@ vg_from->free_count -= pv_pe_count(pv) - pv_pe_alloc_count(pv); vg_to->free_count += pv_pe_count(pv) - pv_pe_alloc_count(pv); - - return 1; } /* FIXME Why not (lv->vg == vg) ? */ @@ -230,6 +221,7 @@ int opt; int active; int existing_vg; + struct pv_list *pvl; if (argc < 3) { log_error("Existing VG, new VG and physical volumes required."); @@ -312,8 +304,13 @@ /* Move PVs across to new structure */ for (opt = 0; opt < argc; opt++) { - if (!_move_pv(vg_from, vg_to, argv[opt])) + if (!(pvl = find_pv_in_vg(vg_from, argv[opt]))) { + log_error("Physical volume %s not in volume group %s", + argv[opt], vg_from->name); goto error; + } + + _move_pv(vg_from, vg_to, pvl); } /* Move required LVs across, checking consistency */
next reply other threads:[~2008-02-29 0:13 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-29 0:13 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2009-09-02 21:27 wysochanski 2009-09-02 21:27 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:25 wysochanski 2009-07-09 5:41 wysochanski 2009-07-08 14:27 wysochanski 2009-07-01 17:04 wysochanski 2009-06-10 11:21 mbroz 2009-06-09 14:31 wysochanski 2008-04-15 14:57 agk 2008-04-10 21:34 wysochanski 2008-04-10 20:02 agk 2008-04-10 2:15 wysochanski 2008-04-10 1:30 wysochanski 2008-01-22 3:49 wysochanski 2008-01-11 20:17 wysochanski 2007-11-15 2:53 agk 2007-07-23 21:10 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080229001348.5326.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).