public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools vgsplit.c Date: Wed, 02 Sep 2009 21:25:00 -0000 [thread overview] Message-ID: <20090902212545.11411.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-09-02 21:25:45 Modified files: tools : vgsplit.c Log message: Refactor vgsplit to move existing_vg logic in a separate 'if' statement. This will aid in future refactorings and allow for us to reorder the source and destination vg based on alphabetical names. Should be no functional change. Author: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.85&r2=1.86 --- LVM2/tools/vgsplit.c 2009/07/14 02:16:05 1.85 +++ LVM2/tools/vgsplit.c 2009/09/02 21:25:44 1.86 @@ -290,6 +290,11 @@ goto bad2; } + } else if (vg_read_error(vg_to) == SUCCESS) { + existing_vg = 0; + } + + if (existing_vg) { if (new_vg_option_specified(cmd)) { log_error("Volume group \"%s\" exists, but new VG " "option specified", vg_name_to); @@ -297,9 +302,7 @@ } if (!vgs_are_compatible(cmd, vg_from,vg_to)) goto_bad; - } else if (vg_read_error(vg_to) == SUCCESS) { - existing_vg = 0; - + } else { vp_def.vg_name = NULL; vp_def.extent_size = vg_from->extent_size; vp_def.max_pv = vg_from->max_pv;
next reply other threads:[~2009-09-02 21:25 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-09-02 21:25 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2009-09-02 21:27 wysochanski 2009-09-02 21:27 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-07-09 5:41 wysochanski 2009-07-08 14:27 wysochanski 2009-07-01 17:04 wysochanski 2009-06-10 11:21 mbroz 2009-06-09 14:31 wysochanski 2008-04-15 14:57 agk 2008-04-10 21:34 wysochanski 2008-04-10 20:02 agk 2008-04-10 2:15 wysochanski 2008-04-10 1:30 wysochanski 2008-02-29 0:13 wysochanski 2008-01-22 3:49 wysochanski 2008-01-11 20:17 wysochanski 2007-11-15 2:53 agk 2007-07-23 21:10 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090902212545.11411.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).