public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools vgsplit.c Date: Wed, 08 Jul 2009 14:27:00 -0000 [thread overview] Message-ID: <20090708142738.17885.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-08 14:27:38 Modified files: tools : vgsplit.c Log message: Remove LOCK_KEEP and READ_CHECK_EXISTENCE from vgsplit. Remove LOCK_KEEP and READ_CHECK_EXISTENCE from vgsplit. These flags are no longer necessary. We now check for existence in a differnet function, and it is not necessary to keep the lock. Removing these flags simplifies the new vg_read() interface. After this patch, we can fully remove LOCK_KEEP. READ_CHECK_EXISTENCE needs a bit more work before full removal. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.78&r2=1.79 --- LVM2/tools/vgsplit.c 2009/07/07 01:18:35 1.78 +++ LVM2/tools/vgsplit.c 2009/07/08 14:27:37 1.79 @@ -342,11 +342,13 @@ existing_vg = 1; vg_to = vg_read_for_update(cmd, vg_name_to, NULL, READ_REQUIRE_RESIZEABLE | - LOCK_NONBLOCKING | LOCK_KEEP | - READ_CHECK_EXISTENCE); + LOCK_NONBLOCKING); - if (vg_read_error(vg_to)) - goto_bad; + if (vg_read_error(vg_to)) { + vg_release(vg_to); + stack; + goto bad2; + } if (new_vg_option_specified(cmd)) { log_error("Volume group \"%s\" exists, but new VG " @@ -483,7 +485,8 @@ r = ECMD_PROCESSED; bad: - unlock_and_release_vg(cmd, vg_from, vg_name_from); unlock_and_release_vg(cmd, vg_to, vg_name_to); +bad2: + unlock_and_release_vg(cmd, vg_from, vg_name_from); return r; }
next reply other threads:[~2009-07-08 14:27 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-08 14:27 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2009-09-02 21:27 wysochanski 2009-09-02 21:27 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:26 wysochanski 2009-09-02 21:25 wysochanski 2009-07-09 5:41 wysochanski 2009-07-01 17:04 wysochanski 2009-06-10 11:21 mbroz 2009-06-09 14:31 wysochanski 2008-04-15 14:57 agk 2008-04-10 21:34 wysochanski 2008-04-10 20:02 agk 2008-04-10 2:15 wysochanski 2008-04-10 1:30 wysochanski 2008-02-29 0:13 wysochanski 2008-01-22 3:49 wysochanski 2008-01-11 20:17 wysochanski 2007-11-15 2:53 agk 2007-07-23 21:10 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090708142738.17885.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).