public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/tools vgcfgbackup.c
@ 2009-07-15  3:30 wysochanski
  0 siblings, 0 replies; only message in thread
From: wysochanski @ 2009-07-15  3:30 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2009-07-15 03:30:04

Modified files:
	tools          : vgcfgbackup.c 

Log message:
	Fix FAILED_INCONSISTENT case in vg_backup_single - typeo on 'if' condition.
	
	In vg_backup_single, we should error out if we vg_read_error(vg) and the
	error code we received was anything other than FAILED_INCONSISTENT.
	Original code contained an error because C operator precedence.
	Note - this was part of the vg_read() so no WHATS_NEW entry neceesary.
	
	Author: Dave Wysochanski <dwysocha@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcfgbackup.c.diff?cvsroot=lvm2&r1=1.28&r2=1.29

--- LVM2/tools/vgcfgbackup.c	2009/07/01 17:00:52	1.28
+++ LVM2/tools/vgcfgbackup.c	2009/07/15 03:30:04	1.29
@@ -54,7 +54,7 @@
 	char **last_filename = (char **)handle;
 	char *filename;
 
-	if (vg_read_error(vg) && !vg_read_error(vg) == FAILED_INCONSISTENT)
+	if (vg_read_error(vg) && (vg_read_error(vg) != FAILED_INCONSISTENT))
 		return ECMD_FAILED;
 
 	if (arg_count(cmd, file_ARG)) {


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-15  3:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-15  3:30 LVM2/tools vgcfgbackup.c wysochanski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).