public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/tools vgcreate.c
@ 2009-12-28 18:34 mbroz
0 siblings, 0 replies; 5+ messages in thread
From: mbroz @ 2009-12-28 18:34 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz@sourceware.org 2009-12-28 18:34:46
Modified files:
tools : vgcreate.c
Log message:
Fix previous vgcreate commit to not call unpaired unlock.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.76&r2=1.77
--- LVM2/tools/vgcreate.c 2009/12/03 19:20:49 1.76
+++ LVM2/tools/vgcreate.c 2009/12/28 18:34:45 1.77
@@ -60,7 +60,8 @@
log_error("A volume group called %s already exists.", vp_new.vg_name);
else
log_error("Can't get lock for %s.", vp_new.vg_name);
- goto bad;
+ vg_release(vg);
+ return ECMD_FAILED;
}
if (!vg_set_extent_size(vg, vp_new.extent_size) ||
@@ -68,7 +69,7 @@
!vg_set_max_pv(vg, vp_new.max_pv) ||
!vg_set_alloc_policy(vg, vp_new.alloc) ||
!vg_set_clustered(vg, vp_new.clustered))
- goto_bad;
+ goto bad_orphan;
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
log_error("Can't get lock for orphan PVs");
^ permalink raw reply [flat|nested] 5+ messages in thread
* LVM2/tools vgcreate.c
@ 2010-02-24 18:15 wysochanski
0 siblings, 0 replies; 5+ messages in thread
From: wysochanski @ 2010-02-24 18:15 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2010-02-24 18:15:40
Modified files:
tools : vgcreate.c
Log message:
Refactor vgcreate to call new vg_change_tag() function.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.77&r2=1.78
--- LVM2/tools/vgcreate.c 2009/12/28 18:34:45 1.77
+++ LVM2/tools/vgcreate.c 2010/02/24 18:15:40 1.78
@@ -94,16 +94,8 @@
goto bad;
}
- if (!(vg->fid->fmt->features & FMT_TAGS)) {
- log_error("Volume group format does not support tags");
- goto bad;
- }
-
- if (!str_list_add(cmd->mem, &vg->tags, tag)) {
- log_error("Failed to add tag %s to volume group %s",
- tag, vp_new.vg_name);
- goto bad;
- }
+ if (!vg_change_tag(vg, tag, 1))
+ goto_bad;
}
if (vg_is_clustered(vg)) {
^ permalink raw reply [flat|nested] 5+ messages in thread
* LVM2/tools vgcreate.c
@ 2009-10-31 17:39 wysochanski
0 siblings, 0 replies; 5+ messages in thread
From: wysochanski @ 2009-10-31 17:39 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2009-10-31 17:39:22
Modified files:
tools : vgcreate.c
Log message:
Update vgcreate to call vg_set_clustered().
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.70&r2=1.71
--- LVM2/tools/vgcreate.c 2009/10/05 20:55:57 1.70
+++ LVM2/tools/vgcreate.c 2009/10/31 17:39:22 1.71
@@ -65,7 +65,8 @@
if (!vg_set_extent_size(vg, vp_new.extent_size) ||
!vg_set_max_lv(vg, vp_new.max_lv) ||
!vg_set_max_pv(vg, vp_new.max_pv) ||
- !vg_set_alloc_policy(vg, vp_new.alloc))
+ !vg_set_alloc_policy(vg, vp_new.alloc) ||
+ !vg_set_clustered(vg, vp_new.clustered))
goto_bad;
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
@@ -103,12 +104,9 @@
}
}
- /* FIXME: move this inside vg_create? */
- if (vp_new.clustered) {
- vg->status |= CLUSTERED;
+ if (vg_is_clustered(vg)) {
clustered_message = "Clustered ";
} else {
- vg->status &= ~CLUSTERED;
if (locking_is_clustered())
clustered_message = "Non-clustered ";
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* LVM2/tools vgcreate.c
@ 2009-06-09 14:30 wysochanski
0 siblings, 0 replies; 5+ messages in thread
From: wysochanski @ 2009-06-09 14:30 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2009-06-09 14:30:45
Modified files:
tools : vgcreate.c
Log message:
Update vgcreate to use new vg_lock_newname().
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.60&r2=1.61
--- LVM2/tools/vgcreate.c 2009/05/13 13:02:56 1.60
+++ LVM2/tools/vgcreate.c 2009/06/09 14:30:44 1.61
@@ -51,7 +51,7 @@
return ECMD_FAILED;
}
- if (!lock_vol(cmd, vp_new.vg_name, LCK_VG_WRITE)) {
+ if (vg_lock_newname(cmd, vp_new.vg_name) != SUCCESS) {
log_error("Can't get lock for %s", vp_new.vg_name);
unlock_vg(cmd, VG_ORPHANS);
return ECMD_FAILED;
^ permalink raw reply [flat|nested] 5+ messages in thread
* LVM2/tools vgcreate.c
@ 2004-03-26 15:46 agk
0 siblings, 0 replies; 5+ messages in thread
From: agk @ 2004-03-26 15:46 UTC (permalink / raw)
To: lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk@sourceware.org 2004-03-26 15:46:38
Modified files:
tools : vgcreate.c
Log message:
indent
Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.39&r2=1.40
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-24 18:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-28 18:34 LVM2/tools vgcreate.c mbroz
-- strict thread matches above, loose matches on Subject: below --
2010-02-24 18:15 wysochanski
2009-10-31 17:39 wysochanski
2009-06-09 14:30 wysochanski
2004-03-26 15:46 agk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).