public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: snitzer@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvconvert.c Date: Fri, 05 Feb 2010 22:47:00 -0000 [thread overview] Message-ID: <20100205224722.12830.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: snitzer@sourceware.org 2010-02-05 22:47:22 Modified files: tools : lvconvert.c Log message: Switch lvconvert_single() over to using get_vg_lock_and_logical_volume() This change was deferred to help ease the review of previous refactoring related to using process_each_lv() for lvconvert's merge support. Not that doing so _really_ helped but... Signed-off-by: Mike Snitzer <snitzer@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.118&r2=1.119 --- LVM2/tools/lvconvert.c 2010/02/05 22:44:38 1.118 +++ LVM2/tools/lvconvert.c 2010/02/05 22:47:22 1.119 @@ -1342,8 +1342,7 @@ static int lvconvert_single(struct cmd_context *cmd, struct lvconvert_params *lp) { - struct volume_group *vg; - struct lv_list *lvl; + struct logical_volume *lv = NULL; int ret = ECMD_FAILED; int saved_ignore_suspended_devices = ignore_suspended_devices(); @@ -1352,36 +1351,29 @@ cmd->handles_missing_pvs = 1; } - log_verbose("Checking for existing volume group \"%s\"", lp->vg_name); - - vg = vg_read_for_update(cmd, lp->vg_name, NULL, 0); - if (vg_read_error(vg)) - goto out; - - if (!(lvl = find_lv_in_vg(vg, lp->lv_name))) { - log_error("Logical volume \"%s\" not found in " - "volume group \"%s\"", lp->lv_name, lp->vg_name); - goto bad; - } + lv = get_vg_lock_and_logical_volume(cmd, lp->vg_name, lp->lv_name); + if (!lv) + goto_out; if (lp->pv_count) { - if (!(lp->pvh = create_pv_list(cmd->mem, vg, lp->pv_count, + if (!(lp->pvh = create_pv_list(cmd->mem, lv->vg, lp->pv_count, lp->pvs, 0))) goto_bad; } else - lp->pvh = &vg->pvs; + lp->pvh = &lv->vg->pvs; - lp->lv_to_poll = lvl->lv; - ret = _lvconvert_single(cmd, lvl->lv, lp); + lp->lv_to_poll = lv; + ret = _lvconvert_single(cmd, lv, lp); bad: unlock_vg(cmd, lp->vg_name); if (ret == ECMD_PROCESSED && lp->need_polling) ret = poll_logical_volume(cmd, lp->lv_to_poll, lp->wait_completion); + + vg_release(lv->vg); out: init_ignore_suspended_devices(saved_ignore_suspended_devices); - vg_release(vg); return ret; }
next reply other threads:[~2010-02-05 22:47 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-02-05 22:47 snitzer [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-19 21:50 jbrassow 2012-02-23 22:36 zkabelac 2012-02-22 16:03 jbrassow 2012-02-22 15:20 jbrassow 2012-02-13 18:38 jbrassow 2012-02-13 18:36 jbrassow 2012-01-25 22:38 zkabelac 2011-12-08 18:00 agk 2011-06-29 2:06 jbrassow 2011-06-28 21:28 jbrassow 2011-01-19 19:24 jbrassow 2010-11-28 18:37 snitzer 2010-07-13 22:04 jbrassow 2010-07-13 21:53 jbrassow 2010-07-01 10:10 mornfall 2010-06-23 20:32 jbrassow 2010-04-28 17:41 jbrassow 2010-04-26 18:12 agk 2010-04-20 12:18 agk 2010-03-31 20:39 agk 2010-01-13 1:49 snitzer 2010-01-13 1:47 snitzer 2010-01-11 17:13 jbrassow 2010-01-07 20:42 jbrassow 2009-10-21 22:19 jbrassow 2009-08-02 21:56 mornfall 2009-06-26 11:29 wysochanski 2009-06-10 15:27 mornfall 2009-05-19 10:27 mbroz 2009-05-19 10:12 mbroz 2008-01-16 22:54 agk 2008-01-16 19:40 agk 2008-01-16 19:16 agk 2007-12-21 1:08 agk 2007-08-01 20:54 jbrassow 2006-05-11 18:56 agk 2006-04-07 14:14 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100205224722.12830.qmail@sourceware.org \ --to=snitzer@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).