public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2 ./WHATS_NEW libdm/ioctl/libdm-iface.c
@ 2010-08-03 13:16 zkabelac
  0 siblings, 0 replies; 3+ messages in thread
From: zkabelac @ 2010-08-03 13:16 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-08-03 13:16:21

Modified files:
	.              : WHATS_NEW 
	libdm/ioctl    : libdm-iface.c 

Log message:
	Fix 'void*' arithmetic warning in some functions from libdm-iface.c.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1691&r2=1.1692
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.78&r2=1.79

--- LVM2/WHATS_NEW	2010/08/03 13:13:01	1.1691
+++ LVM2/WHATS_NEW	2010/08/03 13:16:21	1.1692
@@ -1,5 +1,6 @@
 Version 2.02.73 - 
 ================================
+  Fix 'void*' arithmetic warning in some functions from libdm-iface.c.
   Fix const warning in dev_manager_info() and _dev_manager_lv_rmnodes().
   Fix const warning in archive_file structure from archive.c.
   Clean generated files .exported_symbols_generated, example.conf for distclean.
--- LVM2/libdm/ioctl/libdm-iface.c	2010/08/03 13:06:36	1.78
+++ LVM2/libdm/ioctl/libdm-iface.c	2010/08/03 13:16:21	1.79
@@ -1104,7 +1104,7 @@
 		return _dm_task_get_deps_v1(dmt);
 #endif
 
-	return (struct dm_deps *) (((void *) dmt->dmi.v4) +
+	return (struct dm_deps *) (((char *) dmt->dmi.v4) +
 				   dmt->dmi.v4->data_start);
 }
 
@@ -1115,13 +1115,13 @@
 		return _dm_task_get_names_v1(dmt);
 #endif
 
-	return (struct dm_names *) (((void *) dmt->dmi.v4) +
+	return (struct dm_names *) (((char *) dmt->dmi.v4) +
 				    dmt->dmi.v4->data_start);
 }
 
 struct dm_versions *dm_task_get_versions(struct dm_task *dmt)
 {
-	return (struct dm_versions *) (((void *) dmt->dmi.v4) +
+	return (struct dm_versions *) (((char *) dmt->dmi.v4) +
 				       dmt->dmi.v4->data_start);
 }
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* LVM2 ./WHATS_NEW libdm/ioctl/libdm-iface.c
@ 2010-11-30 22:40 zkabelac
  0 siblings, 0 replies; 3+ messages in thread
From: zkabelac @ 2010-11-30 22:40 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-11-30 22:40:20

Modified files:
	.              : WHATS_NEW 
	libdm/ioctl    : libdm-iface.c 

Log message:
	Add stack trace for error path
	
	If dm_task_set_cookie() fails print stack trace, but keep going on.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1817&r2=1.1818
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.84&r2=1.85

--- LVM2/WHATS_NEW	2010/11/30 22:23:35	1.1817
+++ LVM2/WHATS_NEW	2010/11/30 22:40:19	1.1818
@@ -1,5 +1,6 @@
 Version 2.02.78 - 
 ====================================
+  Add error path stack traces for _process_mapper_dir(), _create_and_load_v4().
   Add missing test for failed pool allocation in write_config_node().
   Replace snprintf with dm_snprintf in clvmd-command.c.
   Check reallocated buffer for NULL before use in clvmd do_command().
--- LVM2/libdm/ioctl/libdm-iface.c	2010/11/30 22:32:44	1.84
+++ LVM2/libdm/ioctl/libdm-iface.c	2010/11/30 22:40:20	1.85
@@ -1779,9 +1779,10 @@
 	if (dmt->cookie_set) {
 		cookie = (dmt->event_nr & ~DM_UDEV_FLAGS_MASK) |
 			 (DM_COOKIE_MAGIC << DM_UDEV_FLAGS_SHIFT);
-		dm_task_set_cookie(dmt, &cookie,
-				   (dmt->event_nr & DM_UDEV_FLAGS_MASK) >>
-				    DM_UDEV_FLAGS_SHIFT);
+		if (!dm_task_set_cookie(dmt, &cookie,
+					(dmt->event_nr & DM_UDEV_FLAGS_MASK) >>
+					DM_UDEV_FLAGS_SHIFT))
+                        stack; /* keep going */
 	}
 
 	if (!dm_task_run(dmt))


^ permalink raw reply	[flat|nested] 3+ messages in thread

* LVM2 ./WHATS_NEW libdm/ioctl/libdm-iface.c
@ 2010-06-23 12:54 zkabelac
  0 siblings, 0 replies; 3+ messages in thread
From: zkabelac @ 2010-06-23 12:54 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-06-23 12:54:47

Modified files:
	.              : WHATS_NEW 
	libdm/ioctl    : libdm-iface.c 

Log message:
	Fix typo: "INTERNAL ERROR" -> "INTERNAL_ERROR"
	
	Author: Xinwei Hu
	xwhu at novell dot com

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1628&r2=1.1629
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.75&r2=1.76

--- LVM2/WHATS_NEW	2010/06/23 12:32:08	1.1628
+++ LVM2/WHATS_NEW	2010/06/23 12:54:46	1.1629
@@ -1,5 +1,6 @@
 Version 2.02.68 -
 ===============================
+  Fix typo "INTERNAL ERROR" -> "INTERNAL_ERROR" in libdm-iface.c.
   Add lv_path to reports to offer full /dev pathname.
   Fix typo in warning message about missing device with allocated data areas.
   Add device name and offset to output of error messages in raw_read_mda_header().
--- LVM2/libdm/ioctl/libdm-iface.c	2010/06/01 16:08:13	1.75
+++ LVM2/libdm/ioctl/libdm-iface.c	2010/06/23 12:54:46	1.76
@@ -777,7 +777,7 @@
 
 	if ((unsigned) dmt->type >=
 	    (sizeof(_cmd_data_v1) / sizeof(*_cmd_data_v1))) {
-		log_error(INTERNAL ERROR "unknown device-mapper task %d",
+		log_error(INTERNAL_ERROR "unknown device-mapper task %d",
 			  dmt->type);
 		goto bad;
 	}


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-11-30 22:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-03 13:16 LVM2 ./WHATS_NEW libdm/ioctl/libdm-iface.c zkabelac
  -- strict thread matches above, loose matches on Subject: below --
2010-11-30 22:40 zkabelac
2010-06-23 12:54 zkabelac

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).