public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/format_pool disk_rep.c
Date: Mon, 20 Dec 2010 14:20:00 -0000 [thread overview]
Message-ID: <20101220142053.29593.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-12-20 14:20:52
Modified files:
lib/format_pool: disk_rep.c
Log message:
Add internal error if pointer is uninitialized
Add simple check for existance of 'pl' and printer internal error message
if device is missing instead of plain crash.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_pool/disk_rep.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18
--- LVM2/lib/format_pool/disk_rep.c 2010/07/09 15:34:44 1.17
+++ LVM2/lib/format_pool/disk_rep.c 2010/12/20 14:20:52 1.18
@@ -263,6 +263,11 @@
*/
if (!sp_count) {
/* FIXME pl left uninitialised if !info->dev */
+ if (!pl) {
+ log_error(INTERNAL_ERROR "device is missing");
+ dm_pool_destroy(tmpmem);
+ return 0;
+ }
sp_count = pl->pd.pl_subpools;
if (!(sp_devs =
dm_pool_zalloc(tmpmem,
next reply other threads:[~2010-12-20 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:20 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-14 18:29 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220142053.29593.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).