public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/lib/format_pool disk_rep.c
@ 2010-12-20 14:20 zkabelac
0 siblings, 0 replies; 2+ messages in thread
From: zkabelac @ 2010-12-20 14:20 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-12-20 14:20:52
Modified files:
lib/format_pool: disk_rep.c
Log message:
Add internal error if pointer is uninitialized
Add simple check for existance of 'pl' and printer internal error message
if device is missing instead of plain crash.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_pool/disk_rep.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18
--- LVM2/lib/format_pool/disk_rep.c 2010/07/09 15:34:44 1.17
+++ LVM2/lib/format_pool/disk_rep.c 2010/12/20 14:20:52 1.18
@@ -263,6 +263,11 @@
*/
if (!sp_count) {
/* FIXME pl left uninitialised if !info->dev */
+ if (!pl) {
+ log_error(INTERNAL_ERROR "device is missing");
+ dm_pool_destroy(tmpmem);
+ return 0;
+ }
sp_count = pl->pd.pl_subpools;
if (!(sp_devs =
dm_pool_zalloc(tmpmem,
^ permalink raw reply [flat|nested] 2+ messages in thread
* LVM2/lib/format_pool disk_rep.c
@ 2005-06-14 18:29 agk
0 siblings, 0 replies; 2+ messages in thread
From: agk @ 2005-06-14 18:29 UTC (permalink / raw)
To: lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk@sourceware.org 2005-06-14 18:29:12
Modified files:
lib/format_pool: disk_rep.c
Log message:
preset pl to NULL
Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/lib/format_pool/disk_rep.c.diff?cvsroot=lvm2&r1=1.3&r2=1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-20 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-20 14:20 LVM2/lib/format_pool disk_rep.c zkabelac
-- strict thread matches above, loose matches on Subject: below --
2005-06-14 18:29 agk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).