LVM2/test t-lvconvert-mirror-basic.sh

LVM2/test t-lvconvert-mirror-basic.sh

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-03-03 12:30:33

Modified files:
	test           : t-lvconvert-mirror-basic.sh 

Log message:
	Do not echo y to lvconvert
	
	This lvconvert is now able to complete operation automatically without question.
	So remove  'echo y |'  - it's breaking pipe on some bash versions.
	
	i.e.:
	+ echo y
	./t-lvconvert-mirror-basic.sh: line 104: echo: write error: Broken pipe
	
	while command has completed this operation succesfully

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-lvconvert-mirror-basic.sh.diff?cvsroot=lvm2&r1=1.7&r2=1.8

--- LVM2/test/t-lvconvert-mirror-basic.sh	2011/01/28 16:07:04	1.7
+++ LVM2/test/t-lvconvert-mirror-basic.sh	2011/03/03 12:30:33	1.8
@@ -101,7 +101,7 @@
 		alloc="--alloc anywhere"
 	fi
 
-	echo y | lvconvert -m $finish_count --mirrorlog $finish_log_type \
+	lvconvert -m $finish_count --mirrorlog $finish_log_type \
 		$vg/$lv1 $alloc
 
 	if ! $active; then

LVM2/test t-lvconvert-mirror-basic.sh

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-01-28 16:07:05

Modified files:
	test           : t-lvconvert-mirror-basic.sh 

Log message:
	Accelerate mirror tests
	
	Instead of recreation of whole device set for each test round,
	just cleanup created LVs to empty VG.
	Lower the size of PV devices to 16MB

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-lvconvert-mirror-basic.sh.diff?cvsroot=lvm2&r1=1.6&r2=1.7

--- LVM2/test/t-lvconvert-mirror-basic.sh	2011/01/11 17:05:09	1.6
+++ LVM2/test/t-lvconvert-mirror-basic.sh	2011/01/28 16:07:04	1.7
@@ -77,8 +77,6 @@
 		max_log_count=$start_log_count
 	fi
 
-	aux prepare_vg 5
-
 	if [ $start_count -gt 0 ]; then
 		# Are there extra devices for the log or do we overlap
 		if [ $(($start_count_p1 + $start_log_count)) -gt ${#dev_array[@]} ]; then
@@ -123,7 +121,7 @@
 	fi
 }
 
-aux prepare_vg 5
+aux prepare_vg 5 16
 
 test_many() {
 	i=$1
@@ -135,7 +133,9 @@
 				: "Testing mirror conversion -m$i/$k -> -m$j/$l"
 				: ----------------------------------------------------
 				test_lvconvert $i $k $j $l 0
+				lvremove -ff $vg
 				test_lvconvert $i $k $j $l 1
+				lvremove -ff $vg
 			done
 		done
 	done

LVM2/test t-lvconvert-mirror-basic.sh

[mornfall]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2010-06-28 19:13:34

Modified files:
	test           : t-lvconvert-mirror-basic.sh 

Log message:
	Minor shell style cleanup.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-lvconvert-mirror-basic.sh.diff?cvsroot=lvm2&r1=1.2&r2=1.3

--- LVM2/test/t-lvconvert-mirror-basic.sh	2010/05/12 13:15:38	1.2
+++ LVM2/test/t-lvconvert-mirror-basic.sh	2010/06/28 19:13:33	1.3
@@ -2,9 +2,9 @@
 
 log_name_to_count()
 {
-	if [ $1 == "mirrored" ]; then
+	if [ "$1" = "mirrored" ]; then
 		echo 2
-	elif [ $1 == "disk" ]; then
+	elif [ "$1" = "disk" ]; then
 		echo 1
 	else
 		echo 0
@@ -44,8 +44,8 @@
 	local active=true
 	local i
 
-	if [ $start_log_type == "disk" ] &&
-		[ $finish_log_type == "mirrored" ]; then
+	if [ "$start_log_type" = "disk" ] &&
+		[ "$finish_log_type" = "mirrored" ]; then
 		echo "FIXME:  disk -> mirrored log conversion not yet supported by LVM"
 		return 0
 	fi