LVM2/tools lvchange.c vgchange.c

LVM2/tools lvchange.c vgchange.c

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-11-03 14:41:18

Modified files:
	tools          : lvchange.c vgchange.c 

Log message:
	Thin avoids need of having writable VG for activation

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.133&r2=1.134
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.127&r2=1.128

--- LVM2/tools/lvchange.c	2011/10/30 22:07:38	1.133
+++ LVM2/tools/lvchange.c	2011/11/03 14:41:18	1.134
@@ -142,10 +142,6 @@
 				    "exclusively", lv->name);
 			if (!activate_lv_excl(cmd, lv))
 				return_0;
-			/* Drop any left thin messages after activation */
-			if (lv_is_thin_volume(lv) &&
-			    !detach_pool_messages(first_seg(lv)->pool_lv))
-				return_0;
 		} else if (activate == CHANGE_ALY) {
 			log_verbose("Activating logical volume \"%s\" locally",
 				    lv->name);
--- LVM2/tools/vgchange.c	2011/10/30 22:07:38	1.127
+++ LVM2/tools/vgchange.c	2011/11/03 14:41:18	1.128
@@ -157,12 +157,6 @@
 				stack;
 				continue;
 			}
-			/* Drop any left thin messages after activation */
-			if (lv_is_thin_volume(lv) &&
-			    !detach_pool_messages(first_seg(lv)->pool_lv)) {
-				stack;
-				continue;
-			}
 		} else if (activate == CHANGE_ALY) {
 			if (!activate_lv_local(cmd, lv)) {
 				stack;

LVM2/tools lvchange.c vgchange.c

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-10-28 20:29:07

Modified files:
	tools          : lvchange.c vgchange.c 

Log message:
	Thin works only with exclusive activation
	
	Enforce exclusive activation with thin targets.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.131&r2=1.132
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.125&r2=1.126

--- LVM2/tools/lvchange.c	2011/10/28 20:28:01	1.131
+++ LVM2/tools/lvchange.c	2011/10/28 20:29:06	1.132
@@ -135,7 +135,9 @@
 		if (!deactivate_lv(cmd, lv))
 			return_0;
 	} else {
-		if (lv_is_origin(lv) || (activate == CHANGE_AE)) {
+		if ((activate == CHANGE_AE) ||
+		    lv_is_origin(lv) ||
+		    lv_is_thin_type(lv)) {
 			log_verbose("Activating logical volume \"%s\" "
 				    "exclusively", lv->name);
 			if (!activate_lv_excl(cmd, lv))
--- LVM2/tools/vgchange.c	2011/10/28 20:28:01	1.125
+++ LVM2/tools/vgchange.c	2011/10/28 20:29:06	1.126
@@ -149,10 +149,10 @@
 				stack;
 				continue;
 			}
-		} else if (lv_is_origin(lv) ||
-			   lv_is_thin_pool(lv) ||
-			   lv_is_thin_volume(lv) ||
-			   (activate == CHANGE_AE)) {
+		} else if ((activate == CHANGE_AE) ||
+			   lv_is_origin(lv) ||
+			   lv_is_thin_type(lv)) {
+			/* FIXME: duplicated test code with lvchange */
 			if (!activate_lv_excl(cmd, lv)) {
 				stack;
 				continue;