bogus test in gnu.testlet.java.net.DatagramPacket.DatagramPacketTest2

bogus test in gnu.testlet.java.net.DatagramPacket.DatagramPacketTest2

[Noa Resare]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

In invalid_addr() in
gnu.testlet.java.net.DatagramPacket.DatagramPacketTest2.java the code
tests if DatagramPacket throws NullPointerException on null InetAddress
and null setAddress() argument.

This is however not specified in either 1.5, 1.4.2 or 1.3.1 API javadoc
and nor implemented in either sun's 1.4.2_05 nor classpath.

Please apply the attached patch that removes the tests in question.

cheers/noa

ps. have anyone looked at the xml output patches?

[-- Attachment #2: mauve-DatagramPacket.patch --]
[-- Type: text/x-patch, Size: 2018 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.676
diff -u -r1.676 ChangeLog
--- ChangeLog	29 Sep 2004 20:00:51 -0000	1.676
+++ ChangeLog	7 Oct 2004 21:55:04 -0000
@@ -1,3 +1,8 @@
+2004-10-07  Noa Resare  <noa@resare.com>
+
+	* gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java
+	(invalid_addr): removed tests for invalid address.
+
 2004-09-29  Tom Tromey  <tromey@redhat.com>
 
 	* gnu/testlet/java/util/Properties/AcuniaPropertiesTest.java
Index: gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java,v
retrieving revision 1.2
diff -u -r1.2 DatagramPacketTest2.java
--- gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java	3 Jun 2004 14:31:09 -0000	1.2
+++ gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java	7 Oct 2004 21:55:04 -0000
@@ -212,42 +212,6 @@
 		}
 	}
 
-	// check for invalid IP address
-	public void invalid_addr()
-	{
-		try
-		{
-			DatagramPacket request = new DatagramPacket(buf, 10, null, PORT);
-			errormsg("invalid_addr", 1, true, "NullPointerException");
-		}
-		catch (NullPointerException e)
-		{
-			harness.check(true);
-		}
-
-		try
-		{
-			DatagramPacket request = new DatagramPacket(buf, 10, ia, PORT);
-			request.setAddress(null);
-			errormsg("invalid_addr", 2, true, "NullPointerException");
-		}
-		catch (NullPointerException e)
-		{
-			harness.check(true);
-		}
-
-		try
-		{
-			DatagramPacket reply = new DatagramPacket(buf, 10);
-			reply.setAddress(null);
-			errormsg("invalid_addr", 3, true, "NullPointerException");
-		}
-		catch (NullPointerException e)
-		{
-			harness.check(true);
-		}
-	}
-
 	// check for invalid port number
 	public void invalid_port()
 	{
@@ -331,7 +295,6 @@
 
 		m.invalid_buf();
 		m.invalid_buflen();
-		m.invalid_addr();
 		m.invalid_port();
 	}
 }