public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Roman Kennke <roman@kennke.org>
To: Mark Wielaard <mark@klomp.org>
Cc: mauve-discuss@sources.redhat.com, classpath@gnu.org
Subject: Re: Updating Mauve tags
Date: Sun, 15 Jan 2006 23:59:00 -0000	[thread overview]
Message-ID: <1137369579.7846.32.camel@localhost.localdomain> (raw)
In-Reply-To: <1137361555.9102.78.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]

Hi Mark,

> > I see that we have a concept of tags in Mauve. That is a collection of
> > keys at the top of each test class. This way we can filter the tests.
> > ATM we have tags for the JDK versions like JDK1.4 JDK1.3 and so on and a
> > couple of other tags. However, it seems that they are not maintained in
> > a usable way, so most people simply include every tag that they can
> > think of (that is what's done in batch_run for example) to run all
> > tests.
> 
> Why do you feel they aren't maintained in a usable way?

This was caused by a misunderstanding of the usage/meaning of those
tags. I was thinking that when a test has the tag JDK1.x, that this test
is meant to PASS under a JDK1.x-ish JDK. As Michael and others have
pointed out on IRC this is not the case. If I want to test a JDK1.3-sh
(for example) environment I should include JDK1.0 JDK1.1 JDK1.2 and
JDK1.3 tags in my keys.

The problem that I am seeing is when a test that is written to PASS
under 1.4 fails under 1.5. There are lots of those tests in the
testsuite for the javax.swing package. So my plan would have been to tag
all tests that pass under JDK1.5 with the 1.5 tag and those that don't
only with JDK1.4 or whatever is ok. Since the tags are not meant to be
used that way, maybe we can do it different. Could we extend the
choose-classes script to detect !JDK1.x tags in the tag header of java
source files and don't include the test in a JDK1.x test run?

/Roman

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2006-01-15 23:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-14 21:33 Roman Kennke
2006-01-15 22:08 ` Mark Wielaard
2006-01-15 23:59   ` Roman Kennke [this message]
2006-01-16 10:25     ` Meskauskas Audrius
2006-01-16 10:32     ` Mark Wielaard
2006-01-16 10:59     ` David Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1137369579.7846.32.camel@localhost.localdomain \
    --to=roman@kennke.org \
    --cc=classpath@gnu.org \
    --cc=mark@klomp.org \
    --cc=mauve-discuss@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).