From: Dr Andrew John Hughes <ahughes@redhat.com>
To: Pavel Tisnovsky <ptisnovs@redhat.com>
Cc: mauve-discuss@sourceware.org
Subject: Re: RFC: fix for Mauve test javax/swing/Border/TitledBorder/constructors.java
Date: Wed, 07 Sep 2011 02:39:00 -0000 [thread overview]
Message-ID: <20110907023849.GI19081@rivendell.middle-earth.co.uk> (raw)
In-Reply-To: <4E60F752.1070308@redhat.com>
On 17:33 Fri 02 Sep , Pavel Tisnovsky wrote:
> Greetings,
>
> here's fix for another Mauve test. In the test
> "javax/swing/Border/TitledBorder/constructors.java" the position of the title in
> the border should be compared with the constant TitledBorder.DEFAULT_POSITION,
> not with TitledBorder.TOP, at least in cases when following constructors are used:
>
> TitledBorder(Border border)
> TitledBorder(Border border, String title)
> TitledBorder(String title)
>
> (there exist three other constructors where title position can be explicitly
> specified, but the fix changes only test cases which use the previous three
> constructors).
>
Can you explain why and note whether this affects current test results?
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
next prev parent reply other threads:[~2011-09-07 2:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 15:31 Pavel Tisnovsky
2011-09-07 2:39 ` Dr Andrew John Hughes [this message]
2011-09-07 12:53 ` Pavel Tisnovsky
2011-09-14 8:55 ` Pavel Tisnovsky
2011-09-14 9:11 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907023849.GI19081@rivendell.middle-earth.co.uk \
--to=ahughes@redhat.com \
--cc=mauve-discuss@sourceware.org \
--cc=ptisnovs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).