public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
* FYI: Improve stack trace output a little
@ 2006-11-26 23:11 Mark Wielaard
  0 siblings, 0 replies; only message in thread
From: Mark Wielaard @ 2006-11-26 23:11 UTC (permalink / raw)
  To: mauve-patches

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Hi,

We would only use the exception class name, but it is better to use the
whole exception, including the message.

2006-11-26  Mark Wielaard  <mark@klomp.org>

        * RunnerProcess.java (getStackTraceString): Use whole exception
        message, not just the class name.

Committed,

Mark

diff -u -r1.15 RunnerProcess.java
--- RunnerProcess.java  13 Oct 2006 11:45:42 -0000      1.15
+++ RunnerProcess.java  26 Nov 2006 23:09:10 -0000
@@ -395,7 +395,7 @@
   private static String getStackTraceString(Throwable ex, String pad)
   {
     StackTraceElement[] st = ex.getStackTrace();
-    StringBuffer sb = new StringBuffer(pad + ex.getClass().getName() + "\n");
+    StringBuffer sb = new StringBuffer(pad + ex.toString() + "\n");
     for (int i = 0; i < st.length; i++)
       sb.append(pad + "at " + st[i].toString() + "\n");
     sb.setLength(sb.length() - 1);


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-11-26 23:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-26 23:11 FYI: Improve stack trace output a little Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).