public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Omair Majid <omajid@redhat.com>
To: Lillian Angel <langel@redhat.com>
Cc: mauve-patches@sources.redhat.com
Subject: Re: [PATCH] Output xml results for tests with compilation problems
Date: Thu, 19 Feb 2009 19:44:00 -0000	[thread overview]
Message-ID: <499DB67D.7090003@redhat.com> (raw)
In-Reply-To: <499DACD4.8030104@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Lillian Angel wrote:
> Omair Majid wrote:
>> The attached patch fixes mauve so that a failure is reported in the xml
>> file. 
> 
> 
> Feel free to commit this.
> 

Thanks. Applied patch as

2009-02-19  Omair Majid  <omajid@redhat.com>

     * RunnerProcess (runtest): If a test fails to start, include it in 
the xml report as a failure.

Cheers,
Omair

[-- Attachment #2: xmloutput.patch --]
[-- Type: text/plain, Size: 1189 bytes --]

? xmloutput-on-failed-to-compile-tests.patch
? xmloutput.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.2136
diff -u -r1.2136 ChangeLog
--- ChangeLog	13 Feb 2009 15:51:58 -0000	1.2136
+++ ChangeLog	19 Feb 2009 19:37:11 -0000
@@ -1,3 +1,8 @@
+2009-02-19  Omair Majid  <omajid@redhat.com>
+
+	* RunnerProcess (runtest): If a test fails to start, include it in the xml
+	report as a failure.
+
 2009-02-13  Omair Majid  <omajid@redhat.com>
 
 	* Harness.java (setupHarness): Check for -xmlout file argument.
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.18
diff -u -r1.18 RunnerProcess.java
--- RunnerProcess.java	11 Jun 2008 10:08:00 -0000	1.18
+++ RunnerProcess.java	19 Feb 2009 19:37:11 -0000
@@ -362,6 +362,10 @@
         if (verbose)
           System.out.println("TEST FAILED: exception when loading "
                              + stripPrefix(name));
+
+        if (report != null)
+          report.addTestResult(currentResult);
+
         return;
       }
 

      reply	other threads:[~2009-02-19 19:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 14:46 Omair Majid
2009-02-19 19:02 ` Lillian Angel
2009-02-19 19:44   ` Omair Majid [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499DB67D.7090003@redhat.com \
    --to=omajid@redhat.com \
    --cc=langel@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).