* [PATCH] Output xml results for tests with compilation problems
@ 2009-02-17 14:46 Omair Majid
2009-02-19 19:02 ` Lillian Angel
0 siblings, 1 reply; 3+ messages in thread
From: Omair Majid @ 2009-02-17 14:46 UTC (permalink / raw)
To: mauve-patches
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
Hi,
When mauve fails to start a test which because of compilation problems,
no xml output is gnenerated:
$ java Harness -vm /usr/bin/java
gnu.java.security.hash.TestOfHashFactory -xmlout output.xml
FAIL: gnu.java.security.hash.TestOfHashFactory
exception when loading:
java.lang.Error: Unresolved compilation problems:
The import gnu.java cannot be resolved
The import gnu.java cannot be resolved
IMessageDigest cannot be resolved to a type
HashFactory cannot be resolved
HashFactory cannot be resolved
[snip]
The xml output file contains no failures:
<?xml version='1.0' encoding='UTF-8'?>
<testreport version='0.1'>
<jvm name='Sun Microsystems Inc.'
version='14.0-b08'
os='Linux 2.6.27.9-159.fc10.i686 i386' />
</testreport>
The attached patch fixes mauve so that a failure is reported in the xml
file.
Cheers,
Omair
[-- Attachment #2: xmloutput-on-failed-to-compile-tests.patch --]
[-- Type: text/plain, Size: 374 bytes --]
--- RunnerProcess.java 11 Jun 2008 10:08:00 -0000
+++ RunnerProcess.java 13 Feb 2009 16:50:41 -0000
@@ -362,6 +362,10 @@
if (verbose)
System.out.println("TEST FAILED: exception when loading "
+ stripPrefix(name));
+
+ if (report != null)
+ report.addTestResult(currentResult);
+
return;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Output xml results for tests with compilation problems
2009-02-17 14:46 [PATCH] Output xml results for tests with compilation problems Omair Majid
@ 2009-02-19 19:02 ` Lillian Angel
2009-02-19 19:44 ` Omair Majid
0 siblings, 1 reply; 3+ messages in thread
From: Lillian Angel @ 2009-02-19 19:02 UTC (permalink / raw)
To: Omair Majid; +Cc: mauve-patches
Omair Majid wrote:
> Hi,
>
> When mauve fails to start a test which because of compilation problems,
> no xml output is gnenerated:
>
> $ java Harness -vm /usr/bin/java
> gnu.java.security.hash.TestOfHashFactory -xmlout output.xml
> FAIL: gnu.java.security.hash.TestOfHashFactory
> exception when loading:
> java.lang.Error: Unresolved compilation problems:
> The import gnu.java cannot be resolved
> The import gnu.java cannot be resolved
> IMessageDigest cannot be resolved to a type
> HashFactory cannot be resolved
> HashFactory cannot be resolved
> [snip]
>
> The xml output file contains no failures:
> <?xml version='1.0' encoding='UTF-8'?>
> <testreport version='0.1'>
> <jvm name='Sun Microsystems Inc.'
> version='14.0-b08'
> os='Linux 2.6.27.9-159.fc10.i686 i386' />
> </testreport>
>
> The attached patch fixes mauve so that a failure is reported in the xml
> file.
Feel free to commit this.
Lillian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Output xml results for tests with compilation problems
2009-02-19 19:02 ` Lillian Angel
@ 2009-02-19 19:44 ` Omair Majid
0 siblings, 0 replies; 3+ messages in thread
From: Omair Majid @ 2009-02-19 19:44 UTC (permalink / raw)
To: Lillian Angel; +Cc: mauve-patches
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Lillian Angel wrote:
> Omair Majid wrote:
>> The attached patch fixes mauve so that a failure is reported in the xml
>> file.
>
>
> Feel free to commit this.
>
Thanks. Applied patch as
2009-02-19 Omair Majid <omajid@redhat.com>
* RunnerProcess (runtest): If a test fails to start, include it in
the xml report as a failure.
Cheers,
Omair
[-- Attachment #2: xmloutput.patch --]
[-- Type: text/plain, Size: 1189 bytes --]
? xmloutput-on-failed-to-compile-tests.patch
? xmloutput.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.2136
diff -u -r1.2136 ChangeLog
--- ChangeLog 13 Feb 2009 15:51:58 -0000 1.2136
+++ ChangeLog 19 Feb 2009 19:37:11 -0000
@@ -1,3 +1,8 @@
+2009-02-19 Omair Majid <omajid@redhat.com>
+
+ * RunnerProcess (runtest): If a test fails to start, include it in the xml
+ report as a failure.
+
2009-02-13 Omair Majid <omajid@redhat.com>
* Harness.java (setupHarness): Check for -xmlout file argument.
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.18
diff -u -r1.18 RunnerProcess.java
--- RunnerProcess.java 11 Jun 2008 10:08:00 -0000 1.18
+++ RunnerProcess.java 19 Feb 2009 19:37:11 -0000
@@ -362,6 +362,10 @@
if (verbose)
System.out.println("TEST FAILED: exception when loading "
+ stripPrefix(name));
+
+ if (report != null)
+ report.addTestResult(currentResult);
+
return;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-19 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-17 14:46 [PATCH] Output xml results for tests with compilation problems Omair Majid
2009-02-19 19:02 ` Lillian Angel
2009-02-19 19:44 ` Omair Majid
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).