Re: RFC: Fix java.awt.Dialog.size

[Lillian Angel <langel@redhat.com>]

Mark Wielaard wrote:
> Hi Omair,
>
> On Mon, 2009-03-23 at 16:25 -0400, Omair Majid wrote:
>   
>> This patch fixes an issue in the java.awt.Dialog.size test where the 
>> Dialog was shown and then a component was added to it, causing the 
>> preferred size to become more than the actual size.
>>
>> Works with IcedTea6 and gij  4.3.2
>>
>> Changelog:
>> 2009-03-23  Omair Majid  <omajid@redhat.com>
>>
>> 	* gnu/testlet/java/awt/Dialog/size.java (test): First add any
>> 	components to the Dialog, then pack it before testing preferred
>> 	size and actual size.
>>     
>
> The original version of this test had "Dialog should be shown at
> preferred size when pack is not called before show." Which is probably
> why pack() wasn't in the original. I am not sure that is a legal
> assumption though. So adding the pack() might be what is needed here. It
> depends on what you want to test. Maybe Lillian remembers, she added the
> test originally.


I wish I had a better recollection of writing this test. If that is not 
a legal assumption, then I am ok with the test being changed.


Lillian