public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Omair Majid <omajid@redhat.com>
To: mauve-patches@sources.redhat.com
Subject: RFC: Fix java.awt.Dialog.size
Date: Mon, 23 Mar 2009 20:26:00 -0000	[thread overview]
Message-ID: <49C7F01D.5050909@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

This patch fixes an issue in the java.awt.Dialog.size test where the 
Dialog was shown and then a component was added to it, causing the 
preferred size to become more than the actual size.

Works with IcedTea6 and gij  4.3.2

Changelog:
2009-03-23  Omair Majid  <omajid@redhat.com>

	* gnu/testlet/java/awt/Dialog/size.java (test): First add any
	components to the Dialog, then pack it before testing preferred
	size and actual size.

Cheers,
Omair

[-- Attachment #2: dialog-size.patch --]
[-- Type: text/x-patch, Size: 667 bytes --]

Index: gnu/testlet/java/awt/Dialog/size.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Dialog/size.java,v
retrieving revision 1.2
diff -u -r1.2 size.java
--- gnu/testlet/java/awt/Dialog/size.java	2 Nov 2005 16:38:22 -0000	1.2
+++ gnu/testlet/java/awt/Dialog/size.java	23 Mar 2009 20:11:13 -0000
@@ -37,8 +37,9 @@
   public void test(TestHarness harness)      
   {
     Dialog jd = new Dialog(new Frame());
-    jd.show();
     jd.add(new Label("Hello world"));
+    jd.pack();
+    jd.show();
 
     // jd insets may be larger than preferred size
     Dimension pref = jd.getPreferredSize();

             reply	other threads:[~2009-03-23 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23 20:26 Omair Majid [this message]
2009-03-23 22:29 ` Mark Wielaard
2009-03-26 15:53   ` Lillian Angel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C7F01D.5050909@redhat.com \
    --to=omajid@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).