From: Mark Wielaard <mark@klomp.org>
To: Omair Majid <omajid@redhat.com>
Cc: mauve-patches@sources.redhat.com
Subject: Re: RFC: Fix java.awt.Dialog.size
Date: Mon, 23 Mar 2009 22:29:00 -0000 [thread overview]
Message-ID: <1237847368.16095.57.camel@hermans.wildebeest.org> (raw)
In-Reply-To: <49C7F01D.5050909@redhat.com>
Hi Omair,
On Mon, 2009-03-23 at 16:25 -0400, Omair Majid wrote:
> This patch fixes an issue in the java.awt.Dialog.size test where the
> Dialog was shown and then a component was added to it, causing the
> preferred size to become more than the actual size.
>
> Works with IcedTea6 and gij 4.3.2
>
> Changelog:
> 2009-03-23 Omair Majid <omajid@redhat.com>
>
> * gnu/testlet/java/awt/Dialog/size.java (test): First add any
> components to the Dialog, then pack it before testing preferred
> size and actual size.
The original version of this test had "Dialog should be shown at
preferred size when pack is not called before show." Which is probably
why pack() wasn't in the original. I am not sure that is a legal
assumption though. So adding the pack() might be what is needed here. It
depends on what you want to test. Maybe Lillian remembers, she added the
test originally.
Cheers,
Mark
next prev parent reply other threads:[~2009-03-23 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 20:26 Omair Majid
2009-03-23 22:29 ` Mark Wielaard [this message]
2009-03-26 15:53 ` Lillian Angel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237847368.16095.57.camel@hermans.wildebeest.org \
--to=mark@klomp.org \
--cc=mauve-patches@sources.redhat.com \
--cc=omajid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).