public inbox for
help / color / mirror / Atom feed
* [newlib-cygwin] AArch32: Fix the build for M class semihosting
@ 2019-02-11 11:50 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2019-02-11 11:50 UTC (permalink / raw)
  To: newlib-cvs;h=1ba66fe8fa94b2148c12beae9948b0cdf6bf1ffa

commit 1ba66fe8fa94b2148c12beae9948b0cdf6bf1ffa
Author: Tamar Christina <>
Date:   Fri Feb 8 17:13:24 2019 +0000

    AArch32: Fix the build for M class semihosting
    The M class cores don't support Semihosting v2 mixed mode, but we were
    accidentally using the new immediates for it.  My last patch changed the
    immediates which broke the build because doing a full multi-lib build
    including M architectures now results in an assembler error instead of
    silently doing the wrong thing.
    This fixes the issue by changing the defines around such that According
    to the specs any M class build uses the normal semihosting instructions.
    Regtested on arm-none-eabi and no issues, using a build with m class
    multilibs too.

 libgloss/arm/swi.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libgloss/arm/swi.h b/libgloss/arm/swi.h
index 8f50ee7..267d164 100644
--- a/libgloss/arm/swi.h
+++ b/libgloss/arm/swi.h
@@ -30,7 +30,9 @@
 /* Now the SWI numbers and reason codes for RDI (Angel) monitors.  */
-#if defined (SEMIHOST_V2) && defined (SEMIHOST_V2_MIXED_MODE)
+#if defined (SEMIHOST_V2) \
+    && defined (SEMIHOST_V2_MIXED_MODE) \
+    && !defined (THUMB_VXM)
   #define AngelSWI_ARM			0xE10F0070 /* HLT #0xF000 A32.  */
   #ifdef __thumb__
     #define AngelSWI			0xBABC /* HLT #0x3c T32.  */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-02-11 11:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 11:50 [newlib-cygwin] AArch32: Fix the build for M class semihosting Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).