public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jon Turney <jturney@sourceware.org>
To: cygwin-cvs@sourceware.org, newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: testsuite: Drop Adminstrator privileges while running tests
Date: Fri, 14 Jul 2023 15:28:43 +0000 (GMT)	[thread overview]
Message-ID: <20230714152843.EDF40385843E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=fee0c04e30e31d9034276ecb70cc8dd82e33e761

commit fee0c04e30e31d9034276ecb70cc8dd82e33e761
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Tue Jul 11 15:40:09 2023 +0100

    Cygwin: testsuite: Drop Adminstrator privileges while running tests
    
    Test access05 and symlink03 expect operations to fail which succeed when
    we have Adminstrator privileges.
    
    There's perhaps a bit of incoherency here: some XFAILed tests expect to
    run as root (so maybe we need the ability to selectively cygdrop?).
    
    Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>

Diff:
---
 .github/workflows/cygwin.yml           | 1 +
 winsup/doc/faq-programming.xml         | 5 +++--
 winsup/testsuite/winsup.api/winsup.exp | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/cygwin.yml b/.github/workflows/cygwin.yml
index 248a3e4cd..39553d37a 100644
--- a/.github/workflows/cygwin.yml
+++ b/.github/workflows/cygwin.yml
@@ -73,6 +73,7 @@ jobs:
           automake,
           busybox,
           cocom,
+          cygutils-extra,
           dblatex,
           dejagnu,
           docbook-xml45,
diff --git a/winsup/doc/faq-programming.xml b/winsup/doc/faq-programming.xml
index 15ae6eac4..2c684bb2b 100644
--- a/winsup/doc/faq-programming.xml
+++ b/winsup/doc/faq-programming.xml
@@ -697,8 +697,9 @@ Building these programs can be disabled with the <literal>--without-cross-bootst
 option to <literal>configure</literal>.
 </para>
 
-<!-- If you want to run the tests, <literal>dejagnu</literal> and
-     <literal>busybox</literal> are also required. -->
+<!-- If you want to run the tests, <literal>dejagnu</literal>,
+     <literal>busybox</literal> and <literal>cygutils-extra<literal> are also
+     required. -->
 
 <para>
 Building the documentation also requires the <literal>dblatex</literal>,
diff --git a/winsup/testsuite/winsup.api/winsup.exp b/winsup/testsuite/winsup.api/winsup.exp
index fb3e3816c..111509511 100644
--- a/winsup/testsuite/winsup.api/winsup.exp
+++ b/winsup/testsuite/winsup.api/winsup.exp
@@ -64,7 +64,7 @@ foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c $srcdir/$subdir/*/*.{cc
 	    }
 	    file mkdir $tmpdir/$tmpfile
 	    set env(PATH) "$runtime_root:$env(PATH)"
-	    ws_spawn "$cygrun $exec $testdll_tmpdir/$tmpfile > $redirect_output"
+	    ws_spawn "cygdrop $cygrun $exec $testdll_tmpdir/$tmpfile > $redirect_output"
 	    file delete -force $tmpdir/$tmpfile
 	    set env(PATH) "$orig_path"
 	    if { $rv } {

                 reply	other threads:[~2023-07-14 15:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230714152843.EDF40385843E@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).