public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: testsuite: Drop Adminstrator privileges while running tests
@ 2023-07-14 15:28 Jon Turney
0 siblings, 0 replies; only message in thread
From: Jon Turney @ 2023-07-14 15:28 UTC (permalink / raw)
To: cygwin-cvs, newlib-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=fee0c04e30e31d9034276ecb70cc8dd82e33e761
commit fee0c04e30e31d9034276ecb70cc8dd82e33e761
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Tue Jul 11 15:40:09 2023 +0100
Cygwin: testsuite: Drop Adminstrator privileges while running tests
Test access05 and symlink03 expect operations to fail which succeed when
we have Adminstrator privileges.
There's perhaps a bit of incoherency here: some XFAILed tests expect to
run as root (so maybe we need the ability to selectively cygdrop?).
Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
Diff:
---
.github/workflows/cygwin.yml | 1 +
winsup/doc/faq-programming.xml | 5 +++--
winsup/testsuite/winsup.api/winsup.exp | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/cygwin.yml b/.github/workflows/cygwin.yml
index 248a3e4cd..39553d37a 100644
--- a/.github/workflows/cygwin.yml
+++ b/.github/workflows/cygwin.yml
@@ -73,6 +73,7 @@ jobs:
automake,
busybox,
cocom,
+ cygutils-extra,
dblatex,
dejagnu,
docbook-xml45,
diff --git a/winsup/doc/faq-programming.xml b/winsup/doc/faq-programming.xml
index 15ae6eac4..2c684bb2b 100644
--- a/winsup/doc/faq-programming.xml
+++ b/winsup/doc/faq-programming.xml
@@ -697,8 +697,9 @@ Building these programs can be disabled with the <literal>--without-cross-bootst
option to <literal>configure</literal>.
</para>
-<!-- If you want to run the tests, <literal>dejagnu</literal> and
- <literal>busybox</literal> are also required. -->
+<!-- If you want to run the tests, <literal>dejagnu</literal>,
+ <literal>busybox</literal> and <literal>cygutils-extra<literal> are also
+ required. -->
<para>
Building the documentation also requires the <literal>dblatex</literal>,
diff --git a/winsup/testsuite/winsup.api/winsup.exp b/winsup/testsuite/winsup.api/winsup.exp
index fb3e3816c..111509511 100644
--- a/winsup/testsuite/winsup.api/winsup.exp
+++ b/winsup/testsuite/winsup.api/winsup.exp
@@ -64,7 +64,7 @@ foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c $srcdir/$subdir/*/*.{cc
}
file mkdir $tmpdir/$tmpfile
set env(PATH) "$runtime_root:$env(PATH)"
- ws_spawn "$cygrun $exec $testdll_tmpdir/$tmpfile > $redirect_output"
+ ws_spawn "cygdrop $cygrun $exec $testdll_tmpdir/$tmpfile > $redirect_output"
file delete -force $tmpdir/$tmpfile
set env(PATH) "$orig_path"
if { $rv } {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-14 15:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-14 15:28 [newlib-cygwin] Cygwin: testsuite: Drop Adminstrator privileges while running tests Jon Turney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).