From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Cc: pfg <pfg@FreeBSD.org>
Subject: [PATCH 5/8] Remove unused __gnu_inline() attribute.
Date: Tue, 04 Apr 2017 07:25:00 -0000 [thread overview]
Message-ID: <1491289499-30548-6-git-send-email-sebastian.huber@embedded-brains.de> (raw)
In-Reply-To: <1491289499-30548-1-git-send-email-sebastian.huber@embedded-brains.de>
From: pfg <pfg@FreeBSD.org>
This was meant to be used by a future FORTIFY_SOURCE implementation.
Probably for good, FORTIFY_SOURCE and this particular GCCism were never
well supported by clang or other compilers. Furthermore, the technology
has long since been replaced by either static checkers, sanitizers, or
even just the strong stack protector that was enabled by default.
Drop __gnu_inline to avoid cluttering the headers.
MFC after: 5 days
---
newlib/libc/include/sys/cdefs.h | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
index ad23232..679425a 100644
--- a/newlib/libc/include/sys/cdefs.h
+++ b/newlib/libc/include/sys/cdefs.h
@@ -537,22 +537,6 @@
__attribute__((__format__ (__strftime__, fmtarg, firstvararg)))
#endif
-/*
- * FORTIFY_SOURCE, and perhaps other compiler-specific features, require
- * the use of non-standard inlining. In general we should try to avoid
- * using these but GCC-compatible compilers tend to support the extensions
- * well enough to use them in limited cases.
- */
-#if defined(__GNUC_GNU_INLINE__) || defined(__GNUC_STDC_INLINE__)
-#if __GNUC_PREREQ__(4, 3) || __has_attribute(__artificial__)
-#define __gnu_inline __attribute__((__gnu_inline__, __artificial__))
-#else
-#define __gnu_inline __attribute__((__gnu_inline__))
-#endif /* artificial */
-#else
-#define __gnu_inline
-#endif
-
/* Compiler-dependent macros that rely on FreeBSD-specific extensions. */
#if defined(__FreeBSD_cc_version) && __FreeBSD_cc_version >= 300001 && \
defined(__GNUC__) && !defined(__INTEL_COMPILER)
--
1.8.4.5
next prev parent reply other threads:[~2017-04-04 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 7:05 Synchronize <sys/cdefs.h> with FreeBSD Sebastian Huber
2017-04-04 7:05 ` [PATCH 1/8] Rename __sentinel to __null_sentinel Sebastian Huber
2017-04-04 7:05 ` [PATCH 6/8] Addition of clang nullability qualifiers Sebastian Huber
2017-04-04 7:05 ` [PATCH 3/8] Fix C++ includability of crypto headers with static array sizes Sebastian Huber
2017-04-04 7:25 ` [PATCH 7/8] don't use C99 static array indices with older GCC versions Sebastian Huber
2017-04-04 7:25 ` [PATCH 2/8] Stop exposing the C11 _Atomic() macro in <sys/cdefs.h>, when compiling for C++. It clashes with the one in libc++'s <atomic> header Sebastian Huber
2017-04-04 7:25 ` [PATCH 4/8] Addition of clang nullability qualifiers Sebastian Huber
2017-04-04 7:25 ` Sebastian Huber [this message]
2017-04-04 7:25 ` [PATCH 8/8] Renumber copyright clause 4 Sebastian Huber
2017-04-04 9:45 ` Synchronize <sys/cdefs.h> with FreeBSD Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491289499-30548-6-git-send-email-sebastian.huber@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
--cc=pfg@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).