public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Cc: pfg <pfg@FreeBSD.org>
Subject: [PATCH 6/8] Addition of clang nullability qualifiers.
Date: Tue, 04 Apr 2017 07:05:00 -0000	[thread overview]
Message-ID: <1491289499-30548-7-git-send-email-sebastian.huber@embedded-brains.de> (raw)
In-Reply-To: <1491289499-30548-1-git-send-email-sebastian.huber@embedded-brains.de>

From: pfg <pfg@FreeBSD.org>

For consistency with the qualifiers added in r310977, define a new
qualifier _Null_unspecified which is also defined in clang 3.7+.

Add two new macros:
__NULLABILITY_PRAGMA_PUSH
__NULLABILITY_PRAGMA_POP

These are for use in headers when we want avoid noisy warnings if
some pointers are left without nullability annotations.

These are added with way ahead of their first use to teach the GCC
ports headers of their existance before their first use.
---
 newlib/libc/include/sys/cdefs.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
index 679425a..fa1692c 100644
--- a/newlib/libc/include/sys/cdefs.h
+++ b/newlib/libc/include/sys/cdefs.h
@@ -634,6 +634,13 @@
 #if !(defined(__clang__) && __has_feature(nullability))
 #define	_Nonnull
 #define	_Nullable
+#define	_Null_unspecified
+#define	__NULLABILITY_PRAGMA_PUSH
+#define	__NULLABILITY_PRAGMA_POP
+#else
+#define	__NULLABILITY_PRAGMA_PUSH _Pragma("clang diagnostic push")	\
+	_Pragma("clang diagnostic ignored \"-Wnullability-completeness\"")
+#define	__NULLABILITY_PRAGMA_POP _Pragma("clang diagnostic pop")
 #endif
 
 /*
-- 
1.8.4.5

  parent reply	other threads:[~2017-04-04  7:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04  7:05 Synchronize <sys/cdefs.h> with FreeBSD Sebastian Huber
2017-04-04  7:05 ` [PATCH 1/8] Rename __sentinel to __null_sentinel Sebastian Huber
2017-04-04  7:05 ` Sebastian Huber [this message]
2017-04-04  7:05 ` [PATCH 3/8] Fix C++ includability of crypto headers with static array sizes Sebastian Huber
2017-04-04  7:25 ` [PATCH 2/8] Stop exposing the C11 _Atomic() macro in <sys/cdefs.h>, when compiling for C++. It clashes with the one in libc++'s <atomic> header Sebastian Huber
2017-04-04  7:25 ` [PATCH 7/8] don't use C99 static array indices with older GCC versions Sebastian Huber
2017-04-04  7:25 ` [PATCH 5/8] Remove unused __gnu_inline() attribute Sebastian Huber
2017-04-04  7:25 ` [PATCH 8/8] Renumber copyright clause 4 Sebastian Huber
2017-04-04  7:25 ` [PATCH 4/8] Addition of clang nullability qualifiers Sebastian Huber
2017-04-04  9:45 ` Synchronize <sys/cdefs.h> with FreeBSD Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491289499-30548-7-git-send-email-sebastian.huber@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=newlib@sourceware.org \
    --cc=pfg@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).