From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Cc: avg <avg@FreeBSD.org>
Subject: [PATCH 7/8] don't use C99 static array indices with older GCC versions
Date: Tue, 04 Apr 2017 07:25:00 -0000 [thread overview]
Message-ID: <1491289499-30548-8-git-send-email-sebastian.huber@embedded-brains.de> (raw)
In-Reply-To: <1491289499-30548-1-git-send-email-sebastian.huber@embedded-brains.de>
From: avg <avg@FreeBSD.org>
For example, the FreeBSD GCC (4.2.1) has a spotty support for that
feature. If the static keyword is used with an unnamed array parameter
in a function declaration, then the compilation fails with:
error: static or type qualifiers in abstract declarator
The feature does work if the parameter is named.
So, the restriction introduced in this commit can be removed when all
affected function prototypes have the workaround.
MFC after: 1 week
Sponsored by: Panzura
---
newlib/libc/include/sys/cdefs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
index fa1692c..280aefd 100644
--- a/newlib/libc/include/sys/cdefs.h
+++ b/newlib/libc/include/sys/cdefs.h
@@ -369,6 +369,7 @@
* void bar(int myArray[__min_size(10)]);
*/
#if !defined(__cplusplus) && \
+ (defined(__clang__) || __GNUC_PREREQ__(4, 6)) && \
(!defined(__STDC_VERSION__) || (__STDC_VERSION__ >= 199901))
#define __min_size(x) static (x)
#else
--
1.8.4.5
next prev parent reply other threads:[~2017-04-04 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 7:05 Synchronize <sys/cdefs.h> with FreeBSD Sebastian Huber
2017-04-04 7:05 ` [PATCH 3/8] Fix C++ includability of crypto headers with static array sizes Sebastian Huber
2017-04-04 7:05 ` [PATCH 1/8] Rename __sentinel to __null_sentinel Sebastian Huber
2017-04-04 7:05 ` [PATCH 6/8] Addition of clang nullability qualifiers Sebastian Huber
2017-04-04 7:25 ` [PATCH 8/8] Renumber copyright clause 4 Sebastian Huber
2017-04-04 7:25 ` [PATCH 5/8] Remove unused __gnu_inline() attribute Sebastian Huber
2017-04-04 7:25 ` [PATCH 4/8] Addition of clang nullability qualifiers Sebastian Huber
2017-04-04 7:25 ` [PATCH 2/8] Stop exposing the C11 _Atomic() macro in <sys/cdefs.h>, when compiling for C++. It clashes with the one in libc++'s <atomic> header Sebastian Huber
2017-04-04 7:25 ` Sebastian Huber [this message]
2017-04-04 9:45 ` Synchronize <sys/cdefs.h> with FreeBSD Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491289499-30548-8-git-send-email-sebastian.huber@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=avg@FreeBSD.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).