From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: newlib-2.5.0 bug report
Date: Wed, 26 Apr 2017 08:31:00 -0000 [thread overview]
Message-ID: <20170426083058.GE12712@calimero.vinschen.de> (raw)
In-Reply-To: <HE1PR0801MB186596D0E35138E1F655FF6D9C1E0@HE1PR0801MB1865.eurprd08.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Apr 25 18:03, David Binderman wrote:
> Hello there,
>
> newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Char literal compared with pointer 'newp.fname'. Did you intend to dereference it?
>
> Source code is
>
> strcpy ((char *) newp->fname, runp->name);
> while(newp->fname != '\0') newp->fname++;
>
> Maybe better code
>
> strcpy ((char *) newp->fname, runp->name);
> while(*(newp->fname) != '\0') newp->fname++;
>
> Regards
>
> David Binderman
Makes sense. Please send a patch.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-04-26 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 18:03 David Binderman
2017-04-26 8:31 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426083058.GE12712@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).