* newlib-2.5.0 bug report
@ 2017-04-25 18:03 David Binderman
2017-04-26 8:31 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2017-04-25 18:03 UTC (permalink / raw)
To: newlib
Hello there,
newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Char literal compared with pointer 'newp.fname'. Did you intend to dereference it?
Source code is
strcpy ((char *) newp->fname, runp->name);
while(newp->fname != '\0') newp->fname++;
Maybe better code
strcpy ((char *) newp->fname, runp->name);
while(*(newp->fname) != '\0') newp->fname++;
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: newlib-2.5.0 bug report
2017-04-25 18:03 newlib-2.5.0 bug report David Binderman
@ 2017-04-26 8:31 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2017-04-26 8:31 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Apr 25 18:03, David Binderman wrote:
> Hello there,
>
> newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Char literal compared with pointer 'newp.fname'. Did you intend to dereference it?
>
> Source code is
>
> strcpy ((char *) newp->fname, runp->name);
> while(newp->fname != '\0') newp->fname++;
>
> Maybe better code
>
> strcpy ((char *) newp->fname, runp->name);
> while(*(newp->fname) != '\0') newp->fname++;
>
> Regards
>
> David Binderman
Makes sense. Please send a patch.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-26 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 18:03 newlib-2.5.0 bug report David Binderman
2017-04-26 8:31 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).