From: Corinna Vinschen <vinschen@redhat.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: newlib@sourceware.org
Subject: Re: [PATCH v2 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll()
Date: Wed, 05 Jul 2017 11:26:00 -0000 [thread overview]
Message-ID: <20170705112609.GD30902@calimero.vinschen.de> (raw)
In-Reply-To: <20170705085414.12755-1-sebastian.huber@embedded-brains.de>
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Jul 5 10:54, Sebastian Huber wrote:
> Use compiler builtin for ffs(). Remove duplicate implementation from
> Cygwin.
>
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
> newlib/libc/misc/ffs.c | 14 ++-------
> newlib/libc/string/Makefile.am | 5 ++++
> newlib/libc/string/Makefile.in | 64 +++++++++++++++++++++++++++++++++---------
> newlib/libc/string/ffsl.c | 34 ++++++++++++++++++++++
> newlib/libc/string/ffsll.c | 34 ++++++++++++++++++++++
> newlib/libc/string/fls.c | 38 +++++++++++++++++++++++++
> newlib/libc/string/flsl.c | 38 +++++++++++++++++++++++++
> newlib/libc/string/flsll.c | 38 +++++++++++++++++++++++++
> winsup/cygwin/syscalls.cc | 22 ---------------
> 9 files changed, 240 insertions(+), 47 deletions(-)
> create mode 100644 newlib/libc/string/ffsl.c
> create mode 100644 newlib/libc/string/ffsll.c
> create mode 100644 newlib/libc/string/fls.c
> create mode 100644 newlib/libc/string/flsl.c
> create mode 100644 newlib/libc/string/flsll.c
Patchset looks good, please push.
For Cygwin we also need to add the new fls* entry points to
common.din and to the docs. I'll do that later, when you
pushed your patch.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-07-05 11:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 13:34 [PATCH 1/3] Implement bzero() via memset() Sebastian Huber
2017-07-04 13:34 ` [PATCH 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll() Sebastian Huber
2017-07-05 6:06 ` Sebastian Huber
2017-07-05 8:42 ` Corinna Vinschen
2017-07-05 8:54 ` [PATCH v2 " Sebastian Huber
2017-07-05 11:26 ` Corinna Vinschen [this message]
2017-07-27 1:40 ` Kito Cheng
2017-07-27 5:47 ` Sebastian Huber
2017-07-27 6:21 ` Sebastian Huber
2017-07-27 6:38 ` Kito Cheng
2017-07-27 6:40 ` Kito Cheng
2017-07-27 6:50 ` Sebastian Huber
2017-07-27 6:53 ` Kito Cheng
2017-07-27 7:09 ` Sebastian Huber
2017-07-27 7:21 ` Sebastian Huber
2017-07-04 13:34 ` [PATCH 2/3] Synchronize <strings.h> with latest FreeBSD Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705112609.GD30902@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).