From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll()
Date: Wed, 05 Jul 2017 06:06:00 -0000 [thread overview]
Message-ID: <f9e589ed-7e86-93a6-4c87-19a10fb566a0@embedded-brains.de> (raw)
In-Reply-To: <20170704133435.9840-3-sebastian.huber@embedded-brains.de>
On 04/07/17 15:34, Sebastian Huber wrote:
> +int
> +fls(int i)
> +{
> +
> + return (sizeof(i) * CHAR_BIT - __builtin_clz(i));
> +}
I just realized that the result of __builtin_clz(i) is undefined if i ==
0. However, fls(0) should return 0. So this must be changed to:
int
fls(int i)
{
if (i == 0)
return (0);
return (sizeof(i) * CHAR_BIT - __builtin_clz(i));
}
Similar for flsl() and flsll().
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2017-07-05 6:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 13:34 [PATCH 1/3] Implement bzero() via memset() Sebastian Huber
2017-07-04 13:34 ` [PATCH 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll() Sebastian Huber
2017-07-05 6:06 ` Sebastian Huber [this message]
2017-07-05 8:42 ` Corinna Vinschen
2017-07-05 8:54 ` [PATCH v2 " Sebastian Huber
2017-07-05 11:26 ` Corinna Vinschen
2017-07-27 1:40 ` Kito Cheng
2017-07-27 5:47 ` Sebastian Huber
2017-07-27 6:21 ` Sebastian Huber
2017-07-27 6:38 ` Kito Cheng
2017-07-27 6:40 ` Kito Cheng
2017-07-27 6:50 ` Sebastian Huber
2017-07-27 6:53 ` Kito Cheng
2017-07-27 7:09 ` Sebastian Huber
2017-07-27 7:21 ` Sebastian Huber
2017-07-04 13:34 ` [PATCH 2/3] Synchronize <strings.h> with latest FreeBSD Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e589ed-7e86-93a6-4c87-19a10fb566a0@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).