* [PATCH] [libgloss][AArch64] Fix link when nosys.specs is used to link
@ 2017-07-13 10:52 Tamar Christina
2017-07-14 8:40 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Tamar Christina @ 2017-07-13 10:52 UTC (permalink / raw)
To: newlib; +Cc: nd, Richard Earnshaw, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Hi All,
This patch fixes the issue where nosys.specs is used to link.
e.g. The use of crt0 without any support for semihosting requested.
The AArch64 crt0 was missing an #ifdef for the initialise_monitor_handles
which was causing the link to fail. Sorry for missing this before.
Ok for master?
PS. I don't have commit access so if OK can someone apply?
Thanks,
Tamar
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nosys.patch --]
[-- Type: text/x-patch; name="nosys.patch", Size: 567 bytes --]
diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
index ed4dafcb10f0b1cc999d50926c49065285c61658..cbff11a4920c92a9155fc60a14d0693cce5e38ff 100644
--- a/libgloss/aarch64/crt0.S
+++ b/libgloss/aarch64/crt0.S
@@ -144,8 +144,10 @@
sub x2, x2, x0 /* Third arg: length of block */
bl FUNCTION (memset)
+#ifdef ARM_RDI_MONITOR
/* Need to set up standard file handles */
bl FUNCTION (initialise_monitor_handles)
+#endif
/* .init and .fini sections are used to create constructors
and destructors. Here we call the _init function and arrange
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [libgloss][AArch64] Fix link when nosys.specs is used to link
2017-07-13 10:52 [PATCH] [libgloss][AArch64] Fix link when nosys.specs is used to link Tamar Christina
@ 2017-07-14 8:40 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2017-07-14 8:40 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On Jul 13 10:52, Tamar Christina wrote:
> Hi All,
>
> This patch fixes the issue where nosys.specs is used to link.
> e.g. The use of crt0 without any support for semihosting requested.
>
> The AArch64 crt0 was missing an #ifdef for the initialise_monitor_handles
> which was causing the link to fail. Sorry for missing this before.
>
> Ok for master?
>
> PS. I don't have commit access so if OK can someone apply?
>
> Thanks,
> Tamar
> diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
> index ed4dafcb10f0b1cc999d50926c49065285c61658..cbff11a4920c92a9155fc60a14d0693cce5e38ff 100644
> --- a/libgloss/aarch64/crt0.S
> +++ b/libgloss/aarch64/crt0.S
> @@ -144,8 +144,10 @@
> sub x2, x2, x0 /* Third arg: length of block */
> bl FUNCTION (memset)
>
> +#ifdef ARM_RDI_MONITOR
> /* Need to set up standard file handles */
> bl FUNCTION (initialise_monitor_handles)
> +#endif
>
> /* .init and .fini sections are used to create constructors
> and destructors. Here we call the _init function and arrange
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-14 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13 10:52 [PATCH] [libgloss][AArch64] Fix link when nosys.specs is used to link Tamar Christina
2017-07-14 8:40 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).