public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.
@ 2017-07-17  8:14 Tamar Christina
  2017-07-17  9:07 ` Corinna Vinschen
  0 siblings, 1 reply; 4+ messages in thread
From: Tamar Christina @ 2017-07-17  8:14 UTC (permalink / raw)
  To: newlib; +Cc: nd

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

Hi All,

This patch adds support for building in a different directory than the default output
directory by preserving DESTDIR value in recursive calls.

OK for master?

PS. I do not have commit rights.

Thanks,
Tamar

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libgloss-destdir.patch --]
[-- Type: text/x-patch; name="libgloss-destdir.patch", Size: 487 bytes --]

diff --git a/libgloss/multi-build.in b/libgloss/multi-build.in
index e2fd0807af07ec4617dbc0d8e9e8427992fc2168..1403eb35e62321f999a99e46c685c2f5659633b1 100644
--- a/libgloss/multi-build.in
+++ b/libgloss/multi-build.in
@@ -45,7 +45,7 @@ multi-do:
 		    LIBCXXFLAGS="$(LIBCXXFLAGS)" \
 		    LDFLAGS="$(LDFLAGS)" \
 		    MULTIFLAGS="" \
-		    DESTDIR="" \
+		    DESTDIR="$(DESTDIR)" \
 		    SOURCE="${srcdir}/" \
 		    INSTALL="$(INSTALL)" \
 		    INSTALL_DATA="$(INSTALL_DATA)" \

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.
  2017-07-17  8:14 [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds Tamar Christina
@ 2017-07-17  9:07 ` Corinna Vinschen
  2017-07-17  9:37   ` Tamar Christina
  0 siblings, 1 reply; 4+ messages in thread
From: Corinna Vinschen @ 2017-07-17  9:07 UTC (permalink / raw)
  To: newlib

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi Tamar,

On Jul 17 08:14, Tamar Christina wrote:
> Hi All,
> 
> This patch adds support for building in a different directory than the default output
> directory by preserving DESTDIR value in recursive calls.
> 
> OK for master?
> 
> PS. I do not have commit rights.
> 
> Thanks,
> Tamar

Would you mind to send patches in `git format-patch' format?  Most
of the above text doesn't exactly qualify for a git log message ;)


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.
  2017-07-17  9:07 ` Corinna Vinschen
@ 2017-07-17  9:37   ` Tamar Christina
  2017-07-17 11:43     ` Corinna Vinschen
  0 siblings, 1 reply; 4+ messages in thread
From: Tamar Christina @ 2017-07-17  9:37 UTC (permalink / raw)
  To: newlib; +Cc: nd

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Ah, oops!

Sorry I, did make the format-patch version but then habit kicked in and I
sent the normal patch!

Here's the correct one.

Thanks!
________________________________________
From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Corinna Vinschen <vinschen@redhat.com>
Sent: Monday, July 17, 2017 10:07 AM
To: newlib@sourceware.org
Subject: Re: [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.

Hi Tamar,

On Jul 17 08:14, Tamar Christina wrote:
> Hi All,
>
> This patch adds support for building in a different directory than the default output
> directory by preserving DESTDIR value in recursive calls.
>
> OK for master?
>
> PS. I do not have commit rights.
>
> Thanks,
> Tamar

Would you mind to send patches in `git format-patch' format?  Most
of the above text doesn't exactly qualify for a git log message ;)


Thanks,
Corinna

--
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Support-building-in-a-different-directory-than-the-d.patch --]
[-- Type: text/x-patch; name="0001-Support-building-in-a-different-directory-than-the-d.patch", Size: 878 bytes --]

From 9b7ef6bd7d5b7174a37095581ae8e2bb38303e3a Mon Sep 17 00:00:00 2001
From: Tamar Christina <tamar.christina@arm.com>
Date: Mon, 17 Jul 2017 08:46:45 +0100
Subject: [PATCH] Support building in a different directory than the default
 output directory by preserving DESTDIR value in recursive calls.

Signed-off-by: Tamar Christina <tamar.christina@arm.com>
---
 libgloss/multi-build.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgloss/multi-build.in b/libgloss/multi-build.in
index e2fd0807a..1403eb35e 100644
--- a/libgloss/multi-build.in
+++ b/libgloss/multi-build.in
@@ -45,7 +45,7 @@ multi-do:
 		    LIBCXXFLAGS="$(LIBCXXFLAGS)" \
 		    LDFLAGS="$(LDFLAGS)" \
 		    MULTIFLAGS="" \
-		    DESTDIR="" \
+		    DESTDIR="$(DESTDIR)" \
 		    SOURCE="${srcdir}/" \
 		    INSTALL="$(INSTALL)" \
 		    INSTALL_DATA="$(INSTALL_DATA)" \
-- 
2.13.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.
  2017-07-17  9:37   ` Tamar Christina
@ 2017-07-17 11:43     ` Corinna Vinschen
  0 siblings, 0 replies; 4+ messages in thread
From: Corinna Vinschen @ 2017-07-17 11:43 UTC (permalink / raw)
  To: newlib

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

On Jul 17 09:37, Tamar Christina wrote:
> Ah, oops!
> 
> Sorry I, did make the format-patch version but then habit kicked in and I
> sent the normal patch!
> 
> Here's the correct one.

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-17 11:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17  8:14 [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds Tamar Christina
2017-07-17  9:07 ` Corinna Vinschen
2017-07-17  9:37   ` Tamar Christina
2017-07-17 11:43     ` Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).