public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] libc/include/newlib.h: Fix C++ compilation issue
Date: Tue, 10 Nov 2020 09:45:45 +0100	[thread overview]
Message-ID: <20201110084545.GB33165@calimero.vinschen.de> (raw)
In-Reply-To: <1604957620-8058-1-git-send-email-joel@rtems.org>

On Nov  9 15:33, Joel Sherrill wrote:
> ---
>  newlib/libc/include/devctl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/libc/include/devctl.h b/newlib/libc/include/devctl.h
> index 889693e..46305cf 100644
> --- a/newlib/libc/include/devctl.h
> +++ b/newlib/libc/include/devctl.h
> @@ -69,10 +69,10 @@ int posix_devctl(
>    size_t           nbyte,
>    int *__restrict  dev_info_ptr
>  );
> -#endif
>  
>  #ifdef __cplusplus
>  }
>  #endif
>  
> -#endif
> +#endif /* _POSIX_26_C_SOURCE */
> +#endif /*_POSIX_DEVCTL_h_ */
> -- 
> 1.8.3.1

LGTM, but maybe you should add a /* __rtems__ */ comment in line 54,
too.  Please push.


Thanks,
Corinna


      reply	other threads:[~2020-11-10  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 21:33 Joel Sherrill
2020-11-10  8:45 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110084545.GB33165@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).