public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] libc/include/newlib.h: Fix C++ compilation issue
@ 2020-11-09 21:33 Joel Sherrill
  2020-11-10  8:45 ` Corinna Vinschen
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Sherrill @ 2020-11-09 21:33 UTC (permalink / raw)
  To: newlib

---
 newlib/libc/include/devctl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/include/devctl.h b/newlib/libc/include/devctl.h
index 889693e..46305cf 100644
--- a/newlib/libc/include/devctl.h
+++ b/newlib/libc/include/devctl.h
@@ -69,10 +69,10 @@ int posix_devctl(
   size_t           nbyte,
   int *__restrict  dev_info_ptr
 );
-#endif
 
 #ifdef __cplusplus
 }
 #endif
 
-#endif
+#endif /* _POSIX_26_C_SOURCE */
+#endif /*_POSIX_DEVCTL_h_ */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libc/include/newlib.h: Fix C++ compilation issue
  2020-11-09 21:33 [PATCH] libc/include/newlib.h: Fix C++ compilation issue Joel Sherrill
@ 2020-11-10  8:45 ` Corinna Vinschen
  0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-11-10  8:45 UTC (permalink / raw)
  To: newlib

On Nov  9 15:33, Joel Sherrill wrote:
> ---
>  newlib/libc/include/devctl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/libc/include/devctl.h b/newlib/libc/include/devctl.h
> index 889693e..46305cf 100644
> --- a/newlib/libc/include/devctl.h
> +++ b/newlib/libc/include/devctl.h
> @@ -69,10 +69,10 @@ int posix_devctl(
>    size_t           nbyte,
>    int *__restrict  dev_info_ptr
>  );
> -#endif
>  
>  #ifdef __cplusplus
>  }
>  #endif
>  
> -#endif
> +#endif /* _POSIX_26_C_SOURCE */
> +#endif /*_POSIX_DEVCTL_h_ */
> -- 
> 1.8.3.1

LGTM, but maybe you should add a /* __rtems__ */ comment in line 54,
too.  Please push.


Thanks,
Corinna


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-10  8:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 21:33 [PATCH] libc/include/newlib.h: Fix C++ compilation issue Joel Sherrill
2020-11-10  8:45 ` Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).