Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill <joel.sherrill@oarcorp.com>]

On 6/14/2017 10:49 AM, Jeff Johnston wrote:
> It would have been nicer to ask first, but that said, I am ok with a
> clarification added to the definition.
> 
> For an OS maintainer, changes that add OS-specific changes to existing
> shared files need approval.  That means you may
> make changes to an existing RTEMS section of a header file, but you cannot
> add an RTEMS section to a
> header or source file that did not have such a section without approval.  I
> don't want to have RTEMS stuff added all over the
> place to save you having to have your own version in your directory.

It wasn't a power grab and I am sorry if it was perceived as such.
I didn't intend it to change anything in how anyone in the RTEMS
community approached newlib. We have been users for since before
1995 and have always submitted patches for review before merging.
I am pretty sure I have had the equivalent of write after approval
for 20 years.

I viewed updating that as contact information and a reflection
of existing practice. I post patches and wait for approval
(even for RTEMS specific parts) before committing.

I agree 100% that caution should be exercised when touching
common files. At the same time, sharing common source/header
files has value so it is worth posting patches and going
back and forth.

Again I apologize that more was read into that patch than
was intended.

--joel

> 
> -- Jeff J.
> 
> On Wed, Jun 14, 2017 at 4:50 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Jun 13 16:30, Joel Sherrill wrote:
>>> ---
>>>   newlib/MAINTAINERS | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
>>> index 6117ff4..0bd93ff 100644
>>> --- a/newlib/MAINTAINERS
>>> +++ b/newlib/MAINTAINERS
>>> @@ -45,6 +45,12 @@ aarch64                    Richard Earnshaw        richard.earnshaw@arm.com
>>>   msp430                       DJ Delorie              dj@redhat.com
>>>                        Nick Clifton            nickc@redhat.com
>>>
>>> +                     OS Port Maintainers     (OS alphabetical order)
>>> +
>>> +OS port maintainers may make changes in OS-specific directories, as
>>> +well as OS-specific portions of the build system, without approval.
>>> +
>>> +RTEMS                        Joel Sherrill           joel.sherrill@oarcorp.com
>>>
>>>                        Write After Approval
>>>
>>> @@ -57,3 +63,4 @@ Nick Clifton                        nickc@redhat.com
>>>   Eric Blake                   eblake@redhat.com
>>>   Will Newton                  will.newton@linaro.org
>>>   Sebastian Huber                      sebastian.huber@embedded-brains.de
>>> +Joel Sherrill                        joel.sherrill@oarcorp.com
>>> --
>>> 1.8.3.1
>>
>> On hold.  I'm still discussing this with Jeff.
>>
>>
>> Corinna
>>
>> --
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat