From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
Date: Thu, 22 Jun 2017 08:06:00 -0000 [thread overview]
Message-ID: <c511d969-4045-2787-ad86-038210a90038@embedded-brains.de> (raw)
In-Reply-To: <CAOox84uLfx-KNaCyZq=andhtdaN0CkCRUX4Y+Jz6pvVQ4X5E+Q@mail.gmail.com>
On 14/06/17 17:49, Jeff Johnston wrote:
> It would have been nicer to ask first, but that said, I am ok with a
> clarification added to the definition.
Sorry for the confusion. Since Newlib had already the concept of CPU
Port Maintainers and GCC has CPU/OS Port Maintainers I thought that the
OS Port Maintainers section was just missing when I looked at this file
to add myself to Write After Approval. Joel was missing too, so it
seemed to me that this file was not up to date in general.
>
> For an OS maintainer, changes that add OS-specific changes to existing
> shared files need approval. That means you may
> make changes to an existing RTEMS section of a header file, but you cannot
> add an RTEMS section to a
> header or source file that did not have such a section without approval. I
> don't want to have RTEMS stuff added all over the
> place to save you having to have your own version in your directory.
I think this is clearly stated by:
" OS Port Maintainers (OS alphabetical order)
OS port maintainers may make changes in OS-specific directories, as
well as OS-specific portions of the build system, without approval."
My goal is to get rid of all the __rtems__ defines in shared files.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2017-06-22 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 19:31 Joel Sherrill
2017-06-14 8:50 ` Corinna Vinschen
2017-06-14 15:49 ` Jeff Johnston
2017-06-14 16:07 ` Joel Sherrill
2017-06-22 8:06 ` Sebastian Huber [this message]
2017-10-10 14:36 [PATCH 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS Joel Sherrill
2017-10-10 14:36 ` [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval Joel Sherrill
2017-10-11 10:53 ` Joel Sherrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c511d969-4045-2787-ad86-038210a90038@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).