Re: [PATCH] libgloss: csky: use atexit to call fini-array functions.

Re: [PATCH] libgloss: csky: use atexit to call fini-array functions.

[瞿仙淼]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

Hi,
Could someone review this patch? This is a small change, I would appreciate it if anyone would like to review.
Thanks,
Cooper
------------------------------------------------------------------
From:Xianmiao Qu <cooper.qu@linux.alibaba.com>
Sent At:2023 Jan. 10 (Tue.) 15:59
To:newlib <newlib@sourceware.org>
Cc:Xianmiao Qu <cooper.qu@linux.alibaba.com>
Subject:[PATCH] libgloss: csky: use atexit to call fini-array functions.
__libc_fini_array should be called upon exit to call the
global termination functions in fini-array, use atexit to
register it at __start.
---
 libgloss/csky/crt0.S | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/libgloss/csky/crt0.S b/libgloss/csky/crt0.S
index a0651a734..49f7da364 100644
--- a/libgloss/csky/crt0.S
+++ b/libgloss/csky/crt0.S
@@ -150,6 +150,8 @@ __start:
 * Assember start up done, C codes start here.
 */
 __goto_c:
+ lrw r0, __libc_fini_array # Register global termination functions
+ jbsr atexit # to be called upon exit
 /*jsri main*/
 lrw r5, __libc_init_array
 jsr r5
-- 
2.32.1 (Apple Git-133)

Re: [PATCH] libgloss: csky: use atexit to call fini-array functions.

[Corinna Vinschen]

Hi Cooper,

On Jan 13 10:07, 瞿仙淼 wrote:
> Hi,
> Could someone review this patch? This is a small change, I would
> appreciate it if anyone would like to review.

your original mail didn't make it to the newlib ML, I don't see this in
the archives @ https://sourceware.org/pipermail/newlib/2023/ either.

Can you resend your patch with `git send-email' or as attachment?

But see below.

> ------------------------------------------------------------------
> From:Xianmiao Qu <cooper.qu@linux.alibaba.com>
> Sent At:2023 Jan. 10 (Tue.) 15:59
> To:newlib <newlib@sourceware.org>
> Cc:Xianmiao Qu <cooper.qu@linux.alibaba.com>
> Subject:[PATCH] libgloss: csky: use atexit to call fini-array functions.
> __libc_fini_array should be called upon exit to call the
> global termination functions in fini-array, use atexit to
> register it at __start.

There should be an empty line between the first and the second line of
the commit message.  The text up to the first blank line in a commit
message is treated as the commit title and your message results in a multi
line summary.

Other than that, your patch looks goot to me.


Thanks,
Corinna

[PATCH] libgloss: csky: use atexit to call fini-array functions.

[Xianmiao Qu]

__libc_fini_array should be called upon exit to call the
global termination functions in fini-array, use atexit to
register it at __start.
---
 libgloss/csky/crt0.S | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libgloss/csky/crt0.S b/libgloss/csky/crt0.S
index a0651a734..49f7da364 100644
--- a/libgloss/csky/crt0.S
+++ b/libgloss/csky/crt0.S
@@ -150,6 +150,8 @@ __start:
 	 * Assember start up done, C codes start here.
 	 */
 __goto_c:
+	lrw     r0, __libc_fini_array   # Register global termination functions
+	jbsr    atexit                  #  to be called upon exit
 	/*jsri	main*/
 	lrw	r5, __libc_init_array
 	jsr	r5
-- 
2.32.1 (Apple Git-133)

Re: [PATCH] libgloss: csky: use atexit to call fini-array functions.

[Corinna Vinschen]

Please don't CC me.  I'm subscribed to the newlib ML anyway.  Thanks.

On Jan 13 20:46, Xianmiao Qu wrote:
> __libc_fini_array should be called upon exit to call the
> global termination functions in fini-array, use atexit to
> register it at __start.
> ---
>  libgloss/csky/crt0.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libgloss/csky/crt0.S b/libgloss/csky/crt0.S
> index a0651a734..49f7da364 100644
> --- a/libgloss/csky/crt0.S
> +++ b/libgloss/csky/crt0.S
> @@ -150,6 +150,8 @@ __start:
>  	 * Assember start up done, C codes start here.
>  	 */
>  __goto_c:
> +	lrw     r0, __libc_fini_array   # Register global termination functions
> +	jbsr    atexit                  #  to be called upon exit
>  	/*jsri	main*/
>  	lrw	r5, __libc_init_array
>  	jsr	r5
> -- 
> 2.32.1 (Apple Git-133)

Pushed.


Thanks,
Corinna