From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Eshan dhawan <eshandhawan51@gmail.com>, newlib@sourceware.org
Subject: Re: [PATCH] Remove multiple defination error
Date: Sat, 11 Jul 2020 17:16:41 +0200 [thread overview]
Message-ID: <5de6b501-b0a2-68a6-b5b2-6fb487506f3b@embedded-brains.de> (raw)
In-Reply-To: <20200710224109.18663-1-eshandhawan51@gmail.com>
On 11/07/2020 00:41, Eshan dhawan wrote:
> Signed-off-by: Eshan dhawan<eshandhawan51@gmail.com>
> ---
> newlib/libm/machine/arm/fenv-vfp.c | 7 ++++-
> newlib/libm/machine/arm/fenv.c | 47 +++++++++++++++++++-----------
> 2 files changed, 36 insertions(+), 18 deletions(-)
What are the design goals of this implementation? Should it work with
some sort of run time VFP detection? Should it select the support using
builtin defines?
I would use builtin defines only and then just use a single file.
next prev parent reply other threads:[~2020-07-11 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 22:41 Eshan dhawan
2020-07-11 15:16 ` Sebastian Huber [this message]
2020-07-11 17:18 ` Eshan Dhawan
2020-07-13 5:36 ` Sebastian Huber
2020-07-13 5:48 ` Sebastian Huber
2020-07-14 13:11 ` Joel Sherrill
2020-07-14 16:59 ` Jim Wilson
2020-07-14 17:51 ` Sebastian Huber
2020-07-23 11:54 Eric Bresie
2020-07-23 12:04 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de6b501-b0a2-68a6-b5b2-6fb487506f3b@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=eshandhawan51@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).