From: "Keith Packard" <keithp@keithp.com>
To: Kito Cheng <kito.cheng@gmail.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH 0/2] libm/riscv: Fixing machine-specific fma/sqrt
Date: Thu, 03 Sep 2020 21:51:59 -0700 [thread overview]
Message-ID: <87blim87ps.fsf@keithp.com> (raw)
In-Reply-To: <CA+yXCZARaAT6ZgWu=XKzKur_DgkBvCRhY9WE4OM-aE0cXQ61Qw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
Kito Cheng <kito.cheng@gmail.com> writes:
> Hi Keith:
>
> Thanks! and it's LGTM.
>
> Seems like those issues can't be captured by GCC testsuite, I should
> add more tests to my regular patch review test list :)
I've got a bunch of errno/exception tests that I've written for picolibc
that catch missing errno values, which is what the sqrt difference would
have caused. As for fma, you'd have to construct a test that checked for
the difference between a true fma and (a*b)+c that the general code in
newlib currently uses.
I've now added a test for picolibc to make sure there aren't duplicate
symbols in libm.a and libc.a, but that doesn't make sure you get the
*right* symbols ...
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-09-04 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 20:54 Keith Packard
2020-09-03 20:54 ` [PATCH 1/2] libm/riscv: Fix machine-specific sqrt build process Keith Packard
2020-09-03 20:54 ` [PATCH 2/2] libm/riscv: Use common fma code when necessary Keith Packard
2020-09-04 3:07 ` [PATCH 0/2] libm/riscv: Fixing machine-specific fma/sqrt Kito Cheng
2020-09-04 4:51 ` Keith Packard [this message]
2020-09-07 17:41 ` Joseph Myers
2020-09-07 22:52 ` Keith Packard
2020-09-04 13:11 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blim87ps.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=kito.cheng@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).