From: Kito Cheng <kito.cheng@gmail.com>
To: Yeting Kuo <eddiekuo@andestech.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss.
Date: Thu, 4 Feb 2021 16:18:26 +0800 [thread overview]
Message-ID: <CA+yXCZCJETaEedWp0ha1=tG7YFyQ38Q+g+u9WKn_W=DcrfRNxA@mail.gmail.com> (raw)
In-Reply-To: <20210204073400.14458-1-eddiekuo@andestech.com>
The patch is LGTM, good catch, thanks!
On Thu, Feb 4, 2021 at 3:58 PM Yeting Kuo <eddiekuo@andestech.com> wrote:
>
> From: Yeting Kuo <fakepaper56@gmail.com>
>
> It's more flexible for the positions of .bss and .data.
> ---
> libgloss/riscv/crt0.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S
> index 160c07853..7a4e4e32c 100644
> --- a/libgloss/riscv/crt0.S
> +++ b/libgloss/riscv/crt0.S
> @@ -27,7 +27,7 @@ _start:
> .option pop
>
> # Clear the bss segment
> - la a0, _edata
> + la a0, __bss_start
> la a2, _end
> sub a2, a2, a0
> li a1, 0
> --
> 2.17.0
>
next prev parent reply other threads:[~2021-02-04 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:34 Yeting Kuo
2021-02-04 8:18 ` Kito Cheng [this message]
2021-02-05 9:36 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZCJETaEedWp0ha1=tG7YFyQ38Q+g+u9WKn_W=DcrfRNxA@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=eddiekuo@andestech.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).