* [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss.
@ 2021-02-04 7:34 Yeting Kuo
2021-02-04 8:18 ` Kito Cheng
2021-02-05 9:36 ` Corinna Vinschen
0 siblings, 2 replies; 3+ messages in thread
From: Yeting Kuo @ 2021-02-04 7:34 UTC (permalink / raw)
To: newlib
From: Yeting Kuo <fakepaper56@gmail.com>
It's more flexible for the positions of .bss and .data.
---
libgloss/riscv/crt0.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S
index 160c07853..7a4e4e32c 100644
--- a/libgloss/riscv/crt0.S
+++ b/libgloss/riscv/crt0.S
@@ -27,7 +27,7 @@ _start:
.option pop
# Clear the bss segment
- la a0, _edata
+ la a0, __bss_start
la a2, _end
sub a2, a2, a0
li a1, 0
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss.
2021-02-04 7:34 [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss Yeting Kuo
@ 2021-02-04 8:18 ` Kito Cheng
2021-02-05 9:36 ` Corinna Vinschen
1 sibling, 0 replies; 3+ messages in thread
From: Kito Cheng @ 2021-02-04 8:18 UTC (permalink / raw)
To: Yeting Kuo; +Cc: Newlib
The patch is LGTM, good catch, thanks!
On Thu, Feb 4, 2021 at 3:58 PM Yeting Kuo <eddiekuo@andestech.com> wrote:
>
> From: Yeting Kuo <fakepaper56@gmail.com>
>
> It's more flexible for the positions of .bss and .data.
> ---
> libgloss/riscv/crt0.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S
> index 160c07853..7a4e4e32c 100644
> --- a/libgloss/riscv/crt0.S
> +++ b/libgloss/riscv/crt0.S
> @@ -27,7 +27,7 @@ _start:
> .option pop
>
> # Clear the bss segment
> - la a0, _edata
> + la a0, __bss_start
> la a2, _end
> sub a2, a2, a0
> li a1, 0
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss.
2021-02-04 7:34 [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss Yeting Kuo
2021-02-04 8:18 ` Kito Cheng
@ 2021-02-05 9:36 ` Corinna Vinschen
1 sibling, 0 replies; 3+ messages in thread
From: Corinna Vinschen @ 2021-02-05 9:36 UTC (permalink / raw)
To: newlib
On Feb 4 15:34, Yeting Kuo wrote:
> From: Yeting Kuo <fakepaper56@gmail.com>
>
> It's more flexible for the positions of .bss and .data.
> ---
> libgloss/riscv/crt0.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S
> index 160c07853..7a4e4e32c 100644
> --- a/libgloss/riscv/crt0.S
> +++ b/libgloss/riscv/crt0.S
> @@ -27,7 +27,7 @@ _start:
> .option pop
>
> # Clear the bss segment
> - la a0, _edata
> + la a0, __bss_start
> la a2, _end
> sub a2, a2, a0
> li a1, 0
> --
> 2.17.0
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-05 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 7:34 [PATCH 1/1] RISC-V: Use __bss_start for the starting point of .bss Yeting Kuo
2021-02-04 8:18 ` Kito Cheng
2021-02-05 9:36 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).