public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: David Macek <david.macek.0@gmail.com>
To: newlib@sourceware.org
Subject: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim
Date: Sun, 7 Mar 2021 16:03:54 +0100	[thread overview]
Message-ID: <CAH2Hv8LJXU1K3yJwMxxOCp0mbULra_o9u0fUG5z28t983wbMhA@mail.gmail.com> (raw)

As in fbaa096772f77be664864d80508906ad018cc23b:

Having symlinks leads to issue unpacking the sources on platforms without proper
symlink support.  These platforms mostly extract symlinks from the archive file
as copies of the files the symlinks point to.  If the links appear in the tar
file before the source exists, it cannot copy the file.

The solution in this patch is to convert the files that are symbolic
links into simple files which include the file they were linked to.
This should be more portable and avoids the symbolic link problem.

Signed-off-by: David Macek <david.macek.0@gmail.com>
---

Excuse my ignorance, but is this acceptable?  I'm not sure
what actually happens with these files, but it'd be nice to
get rid of the last symlink in the repo.

 newlib/libc/machine/i386/sys/fenv.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
 mode change 120000 => 100644 newlib/libc/machine/i386/sys/fenv.h

diff --git a/newlib/libc/machine/i386/sys/fenv.h
b/newlib/libc/machine/i386/sys/fenv.h
deleted file mode 120000
index 218057825e..0000000000
--- a/newlib/libc/machine/i386/sys/fenv.h
+++ /dev/null
@@ -1 +0,0 @@
-../../x86_64/sys/fenv.h
\ No newline at end of file
diff --git a/newlib/libc/machine/i386/sys/fenv.h
b/newlib/libc/machine/i386/sys/fenv.h
new file mode 100644
index 0000000000..d2c41a6d5a
--- /dev/null
+++ b/newlib/libc/machine/i386/sys/fenv.h
@@ -0,0 +1,5 @@
+/*
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include "../../x86_64/sys/fenv.h"

-- 
David Macek

             reply	other threads:[~2021-03-07 15:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 15:03 David Macek [this message]
2021-03-08  9:59 ` Corinna Vinschen
2021-03-09 19:11   ` David Macek
2021-03-10  9:09     ` Corinna Vinschen
2021-03-11  7:13       ` David Macek
2021-03-11 14:11         ` Corinna Vinschen
2021-03-13 18:11           ` David Macek
2021-03-13 20:05             ` Joel Sherrill
2021-03-23 14:38             ` Corinna Vinschen
2021-03-24 10:15               ` Corinna Vinschen
2021-04-05  7:37                 ` David Macek
2021-04-06  9:57                   ` Corinna Vinschen
2021-04-07  7:28                     ` David Macek
2021-04-07  9:28                       ` Corinna Vinschen
2021-04-07 16:16                         ` David Macek
2021-04-13 11:00                           ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH2Hv8LJXU1K3yJwMxxOCp0mbULra_o9u0fUG5z28t983wbMhA@mail.gmail.com \
    --to=david.macek.0@gmail.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).