From: David Macek <david.macek.0@gmail.com>
To: newlib@sourceware.org
Cc: Corinna Vinschen <vinschen@redhat.com>
Subject: Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim
Date: Thu, 11 Mar 2021 08:13:57 +0100 [thread overview]
Message-ID: <CAH2Hv8LtKkNyWAwRjYRsEhDLjam8oHtzX4AA5rgt6eiHo-6pkw@mail.gmail.com> (raw)
In-Reply-To: <YEiMvHg08HEz8TxH@calimero.vinschen.de>
> > > This doesn't work. The machine-specific header will get installed to
> > > $DESTDIR/usr/include/sys/fenv.h, and it will now include a non-existing
> > > file. We have to keep the symlink or to duplicate the file.
> >
> > How come the newlib/libm/machine/i386/fenv.c non-symlink works? Is it
> > installed differently?
>
> It's not installed at all. It's a source file so the include only has
> to work at build time. The header file on the other hand will be
> installed on the target. As such, the result has to work on the target.
Ah, right. But then I'm confused how a symlink can work in the first
place. I guess some part of the build process copies the contents
instead of the file.
More to the point, how big of an issue would be to duplicate the file?
> > Coincidentally, is newlib/libc/machine/ft32/stpcmp.S file correct?
>
> I have no idea, you have to ask the guys knowing that chip type.
I didn't read the instructions, it's just the label looks wrong. :)
Should I start another thread?
--
David Macek
next prev parent reply other threads:[~2021-03-11 7:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 15:03 David Macek
2021-03-08 9:59 ` Corinna Vinschen
2021-03-09 19:11 ` David Macek
2021-03-10 9:09 ` Corinna Vinschen
2021-03-11 7:13 ` David Macek [this message]
2021-03-11 14:11 ` Corinna Vinschen
2021-03-13 18:11 ` David Macek
2021-03-13 20:05 ` Joel Sherrill
2021-03-23 14:38 ` Corinna Vinschen
2021-03-24 10:15 ` Corinna Vinschen
2021-04-05 7:37 ` David Macek
2021-04-06 9:57 ` Corinna Vinschen
2021-04-07 7:28 ` David Macek
2021-04-07 9:28 ` Corinna Vinschen
2021-04-07 16:16 ` David Macek
2021-04-13 11:00 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2Hv8LtKkNyWAwRjYRsEhDLjam8oHtzX4AA5rgt6eiHo-6pkw@mail.gmail.com \
--to=david.macek.0@gmail.com \
--cc=newlib@sourceware.org \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).