From: C Howland <cc1964t@gmail.com>
To: newlib@sourceware.org
Subject: Re: Fw: [PATCH 0/3] libm: Clean up gamma functions
Date: Thu, 27 Aug 2020 13:43:49 -0400 [thread overview]
Message-ID: <CANk6obSzY7iS1r9fk77=Z=yGD0+JG0kYeqLUV9RxmGG+J4uk+w@mail.gmail.com> (raw)
In-Reply-To: <SN5P110MB0383186ECD9B028A4B0E2ECC9A550@SN5P110MB0383.NAMP110.PROD.OUTLOOK.COM>
> ------------------------------
> *From:* Newlib <newlib-bounces@sourceware.org> on behalf of Keith Packard
> via Newlib <newlib@sourceware.org>
> *Sent:* Wednesday, August 26, 2020 1:03 PM
> *To:* newlib@sourceware.org <newlib@sourceware.org>
> *Subject:* [PATCH 0/3] libm: Clean up gamma functions
>
> EXTERNAL EMAIL - This email originated from outside of CACI. Do not click
> any links or attachments unless you recognize and trust the sender.
>
>
>
>
>
> This series cleans up some API oddities and inaccuracies in
> errno/exception reporting from the various gamma related functions.
> With this series applied, newlib now matches the POSIX spec (and glibc)
> for tgamma/lgamma functions. I've left the 'gamma' functions BSD
> compatible (tgamma instead of lgamma) to avoid changing the API.
>
> [PATCH 1/3] libm: Fix sign value returned from __ieee754_lgamma*_r(-0)
>
> Following the C spec, gamma(-0) should be -INFINITY rather than
> +INFINITY, so the *signgamp value in lgamma should be -1
> rather than +1 for this case.
>
What C spec? Neither C99 nor C11 say so that I see for lgamma(). POSIX
makes the direct statement "If x is a non-positive integer, a pole error
shall occur and lgamma(), lgammaf(), and lgammal() shall return +HUGE_VAL,
+HUGE_VALF, and +HUGE_VALL, respectively." 0, regardless of sign, falls
under that.
https://pubs.opengroup.org/onlinepubs/9699919799/functions/lgamma.html
Additionally, the Linux lgamma man page, using GLIBC, says the same thing
as quoted from POSIX (not word for word, but the identical result).
(POSIX does require the +-0 +-INFINITY for tgamma(). Did these get crossed
up?)
Craig
>
> [PATCH 2/3] libm: Remove __ieee754_gamma_r variants
>
> Back in 2002, a patch changed the various gamma functions so
> that the returned abs(gamma) instead of the ln of gamma. This
> left the _r variants in place, with their extra parameter to
> return the sign of the resulting value. This doesn't make any
> sense to me and looks like it was just a mistake. I've changed
> the __ieee754_gamma functions to apply the sign value locally
> and eliminated the gamma_r versions as those are no longer useful.
>
> [PATCH 3/3] libm: Adjust errno/exception values for gamma/lgamma
>
> There's a pretty detailed discussion in the commit message
> here, the short version is that tgamma and lgamma are
> specified with different errno/exception behaviour for
> one class of inputs (negative integers).
>
next prev parent reply other threads:[~2020-08-27 17:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 17:03 Keith Packard
2020-08-26 17:03 ` [PATCH 1/3] libm: Fix sign value returned from __ieee754_lgamma*_r(-0) Keith Packard
2020-08-26 17:03 ` [PATCH 2/3] libm: Remove __ieee754_gamma_r variants Keith Packard
2020-08-26 18:20 ` Corinna Vinschen
2020-08-26 19:10 ` Keith Packard
2020-08-27 7:24 ` Corinna Vinschen
2020-08-27 17:05 ` Keith Packard
2020-08-28 8:19 ` Corinna Vinschen
2020-08-28 8:34 ` Corinna Vinschen
2020-09-01 16:33 ` Fabian Schriever
2020-09-01 17:23 ` Keith Packard
2020-09-02 8:03 ` Corinna Vinschen
2020-09-02 20:37 ` Keith Packard
2020-09-03 8:04 ` Corinna Vinschen
2020-09-03 15:59 ` Brian Inglis
2020-09-03 21:25 ` Keith Packard
2020-09-03 22:09 ` Brian Inglis
2020-09-04 0:01 ` Keith Packard
2020-09-04 0:27 ` Brian Inglis
2020-09-04 1:37 ` Keith Packard
2020-09-04 13:03 ` Corinna Vinschen
2020-09-04 16:19 ` Keith Packard
2020-08-26 17:03 ` [PATCH 3/3] libm: Adjust errno/exception values for gamma/lgamma Keith Packard
[not found] ` <SN5P110MB0383012287522E8285674CAB9A550@SN5P110MB0383.NAMP110.PROD.OUTLOOK.COM>
2020-08-27 17:55 ` Fw: " C Howland
2020-08-27 19:28 ` Brian Inglis
[not found] ` <SN5P110MB0383186ECD9B028A4B0E2ECC9A550@SN5P110MB0383.NAMP110.PROD.OUTLOOK.COM>
2020-08-27 17:43 ` C Howland [this message]
2020-08-27 23:59 ` Fw: [PATCH 0/3] libm: Clean up gamma functions Keith Packard
2020-08-28 2:03 ` Brian Inglis
2020-08-28 3:13 ` Keith Packard
2020-08-28 3:51 ` Brian Inglis
2020-08-28 17:13 ` Keith Packard
2020-08-28 18:29 ` Joseph Myers
2020-08-28 19:32 ` Keith Packard
2020-08-28 19:53 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANk6obSzY7iS1r9fk77=Z=yGD0+JG0kYeqLUV9RxmGG+J4uk+w@mail.gmail.com' \
--to=cc1964t@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).