From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: newlib@sourceware.org
Subject: Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants
Date: Thu, 3 Sep 2020 16:09:34 -0600 [thread overview]
Message-ID: <7a4384ad-b698-84bf-a0bb-ef796dffdb99@SystematicSw.ab.ca> (raw)
In-Reply-To: <87mu268sdv.fsf@keithp.com>
[-- Attachment #1.1: Type: text/plain, Size: 2109 bytes --]
On 2020-09-03 15:25, Keith Packard wrote:
> Brian Inglis <Brian.Inglis@SystematicSw.ab.ca> writes:
>
>>>> Then tell us what you want gamma and gamma_r to do for Cygwin.
>>>
>>> I did: https://sourceware.org/pipermail/newlib/2020/017946.html
>
> Oops! I appear to have missed that mail.
>
>> FYI docs/spec:
>> https://sca.uwaterloo.ca/coldfire/gcc-doc/docs/libm_21.html#SEC21
>> http://www.ece.ualberta.ca/~cmpe401/docs/coldfire/libm.pdf#page=20
>> https://ftp.rtems.org/pub/rtems/docs/3.2.0/libm-3.2.0.ps - see p.18
>
> That's quite helpful actually and says that cygwin's gamma matches
> glibc, which makes the change from 2002 just a bug. Switching gamma back
> to lgamma is quite simple.
>
> Here's what I did:
>
> 1. Remove the gamma* function implementations and make them explicit
> aliases to lgamma*.
>
> 2. Change the name of the __ieee754_gamma* functions to
> __ieee754_tgamma* and remove the _ieee754_gamma*_r variants
>
> I've sent a patch doing this to the list.
I don't think you can "remove the _ieee754_gamma*_r variants" as I believe
Cygwin has to keep these:
$ nm --defined-only --extern-only /bin/cygwin1.dll | fgrep gamma
00000001801a76c0 T __ieee754_gamma_r
00000001801a7f90 T __ieee754_gammaf_r
00000001801a76e0 T __ieee754_lgamma_r
00000001801a7fb0 T __ieee754_lgammaf_r
000000018018a8c0 T __lgammal_r
000000018018ce10 T __tgammal_r
000000018019f690 T gamma
00000001801a0a40 T gamma_r
00000001801a0200 T gammaf
00000001801a0b80 T gammaf_r
000000018019fb00 T lgamma
00000001801a0ae0 T lgamma_r
00000001801a0660 T lgammaf
00000001801a0c20 T lgammaf_r
000000018018ae10 T lgammal
000000018018ae90 T lgammal_r
000000018019fe50 T tgamma
00000001801a0970 T tgammaf
000000018018d290 T tgammal
although I don't have the Windows utilities to check the exports directly.
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-09-03 22:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 17:03 [PATCH 0/3] libm: Clean up gamma functions Keith Packard
2020-08-26 17:03 ` [PATCH 1/3] libm: Fix sign value returned from __ieee754_lgamma*_r(-0) Keith Packard
2020-08-26 17:03 ` [PATCH 2/3] libm: Remove __ieee754_gamma_r variants Keith Packard
2020-08-26 18:20 ` Corinna Vinschen
2020-08-26 19:10 ` Keith Packard
2020-08-27 7:24 ` Corinna Vinschen
2020-08-27 17:05 ` Keith Packard
2020-08-28 8:19 ` Corinna Vinschen
2020-08-28 8:34 ` Corinna Vinschen
2020-09-01 16:33 ` Fabian Schriever
2020-09-01 17:23 ` Keith Packard
2020-09-02 8:03 ` Corinna Vinschen
2020-09-02 20:37 ` Keith Packard
2020-09-03 8:04 ` Corinna Vinschen
2020-09-03 15:59 ` Brian Inglis
2020-09-03 21:25 ` Keith Packard
2020-09-03 22:09 ` Brian Inglis [this message]
2020-09-04 0:01 ` Keith Packard
2020-09-04 0:27 ` Brian Inglis
2020-09-04 1:37 ` Keith Packard
2020-09-04 13:03 ` Corinna Vinschen
2020-09-04 16:19 ` Keith Packard
2020-08-26 17:03 ` [PATCH 3/3] libm: Adjust errno/exception values for gamma/lgamma Keith Packard
[not found] ` <SN5P110MB0383012287522E8285674CAB9A550@SN5P110MB0383.NAMP110.PROD.OUTLOOK.COM>
2020-08-27 17:55 ` Fw: " C Howland
2020-08-27 19:28 ` Brian Inglis
[not found] ` <SN5P110MB0383186ECD9B028A4B0E2ECC9A550@SN5P110MB0383.NAMP110.PROD.OUTLOOK.COM>
2020-08-27 17:43 ` Fw: [PATCH 0/3] libm: Clean up gamma functions C Howland
2020-08-27 23:59 ` Keith Packard
2020-08-28 2:03 ` Brian Inglis
2020-08-28 3:13 ` Keith Packard
2020-08-28 3:51 ` Brian Inglis
2020-08-28 17:13 ` Keith Packard
2020-08-28 18:29 ` Joseph Myers
2020-08-28 19:32 ` Keith Packard
2020-08-28 19:53 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4384ad-b698-84bf-a0bb-ef796dffdb99@SystematicSw.ab.ca \
--to=brian.inglis@systematicsw.ab.ca \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).