Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants

[Corinna Vinschen <vinschen@redhat.com>]

On Aug 28 10:19, Corinna Vinschen via Newlib wrote:
> On Aug 27 10:05, Keith Packard via Newlib wrote:
> > Corinna Vinschen via Newlib <newlib@sourceware.org> writes:
> > 
> > > Nevertheless, the symbols have to be exported for backward compatibility.
> > > So you're saying aliasing gamma_r to lgamma_r and gammaf_r to lgammaf_r
> > > in the DLLs export table would be sufficient?
> > 
> > It depends if you want the pre-2002 functionality or the post-2002
> > functionality.
> 
> The important point is that gamma_r and gammaf_r are exported by Cygwin
> and must be kept available, otherwise building the DLL fails.  If they
> returned the wrong vaslue, that's a bug and needs fixing.
> 
> Whether gamma_r and gammaf_r are still functions on their own, or if
> they are just defined as aliases to lgamma_r and lgammaf_r in
> winsup/cygwin/common.din, as in
> 
>   gamma_r = lgamma_r NOSIGFE
>   gammaf_r = lgammaf_r NOSIGFE
> 
> is up to you.

On second thought, given gamma_r and gammaf_r are BSD functions,
it might be a good idea to keep the wrapper functions for other
targets as well.

Any input from the RTEMS guys, perhaps?


Thanks,
Corinna