From: Jeff Johnston <jjohnstn@redhat.com>
To: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] Fix nbdm.c build break
Date: Wed, 4 May 2022 13:13:07 -0400 [thread overview]
Message-ID: <CAOox84sFAO75q9s1P-vL+=fB-4zqKXB2RG4HQ5byJUG+oPydCg@mail.gmail.com> (raw)
In-Reply-To: <20220504170304.1633855-1-dimitar@dinux.eu>
Patch merged. Thanks.
-- Jeff J.
On Wed, May 4, 2022 at 1:03 PM Dimitar Dimitrov <dimitar@dinux.eu> wrote:
> The ndbm.c build broke with:
> Commit 357d7fcc6
> In <stdio.h> provide only necessary types
>
> The above commit exposed a latent missing-header bug:
> newlib/newlib/libc/include/ndbm.h:83:38: error: unknown type name
> ‘mode_t’
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> newlib/libc/include/ndbm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/newlib/libc/include/ndbm.h b/newlib/libc/include/ndbm.h
> index c5084b9c2..1e5072cf1 100644
> --- a/newlib/libc/include/ndbm.h
> +++ b/newlib/libc/include/ndbm.h
> @@ -40,6 +40,7 @@
> #ifndef _NDBM_H_
> #define _NDBM_H_
>
> +#include <sys/types.h> /* For mode_t. */
> /* #include <db.h> */
>
> /*
> --
> 2.35.1
>
>
prev parent reply other threads:[~2022-05-04 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 17:03 Dimitar Dimitrov
2022-05-04 17:13 ` Jeff Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84sFAO75q9s1P-vL+=fB-4zqKXB2RG4HQ5byJUG+oPydCg@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).