* [PATCH] riscv: Fix fenv.h support
@ 2023-10-12 10:06 Sebastian Huber
2023-10-12 14:36 ` Kito Cheng
2023-10-12 15:07 ` Jeff Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Huber @ 2023-10-12 10:06 UTC (permalink / raw)
To: newlib; +Cc: Jesse Huang, Kito Cheng
Use the same C preprocessor expressions to define FE_RMODE_MASK and
__RISCV_HARD_FLOAT.
The problem was noticed on GCC 10 which does not define __riscv_f.
---
newlib/libc/machine/riscv/sys/fenv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/machine/riscv/sys/fenv.h b/newlib/libc/machine/riscv/sys/fenv.h
index 1d577d527b..98387d2205 100644
--- a/newlib/libc/machine/riscv/sys/fenv.h
+++ b/newlib/libc/machine/riscv/sys/fenv.h
@@ -14,7 +14,7 @@
#include <stddef.h>
-#if defined(__riscv_f) || defined(__riscv_zfinx)
+#if defined(__riscv_flen) || defined(__riscv_zfinx)
/* Per "The RISC-V Instruction Set Manual: Volume I: User-Level ISA:
* Version 2.1", Section 8.2, "Floating-Point Control and Status
--
2.35.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Fix fenv.h support
2023-10-12 10:06 [PATCH] riscv: Fix fenv.h support Sebastian Huber
@ 2023-10-12 14:36 ` Kito Cheng
2023-10-12 15:07 ` Jeff Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Kito Cheng @ 2023-10-12 14:36 UTC (permalink / raw)
To: Sebastian Huber; +Cc: Newlib, Jesse Huang
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
LGTM, I didn't notice that backwards compatible issue, thanks for fixing
that :)
Sebastian Huber <sebastian.huber@embedded-brains.de> 於 2023年10月12日 週四 03:06
寫道：
> Use the same C preprocessor expressions to define FE_RMODE_MASK and
> __RISCV_HARD_FLOAT.
>
> The problem was noticed on GCC 10 which does not define __riscv_f.
> ---
> newlib/libc/machine/riscv/sys/fenv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/machine/riscv/sys/fenv.h
> b/newlib/libc/machine/riscv/sys/fenv.h
> index 1d577d527b..98387d2205 100644
> --- a/newlib/libc/machine/riscv/sys/fenv.h
> +++ b/newlib/libc/machine/riscv/sys/fenv.h
> @@ -14,7 +14,7 @@
>
> #include <stddef.h>
>
> -#if defined(__riscv_f) || defined(__riscv_zfinx)
> +#if defined(__riscv_flen) || defined(__riscv_zfinx)
>
> /* Per "The RISC-V Instruction Set Manual: Volume I: User-Level ISA:
> * Version 2.1", Section 8.2, "Floating-Point Control and Status
> --
> 2.35.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Fix fenv.h support
2023-10-12 10:06 [PATCH] riscv: Fix fenv.h support Sebastian Huber
2023-10-12 14:36 ` Kito Cheng
@ 2023-10-12 15:07 ` Jeff Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnston @ 2023-10-12 15:07 UTC (permalink / raw)
To: Sebastian Huber; +Cc: newlib, Jesse Huang, Kito Cheng
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
Feel free to merge. The file already mentions __riscv_flen in the #else
clause.
-- Jeff J.
On Thu, Oct 12, 2023 at 6:06 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:
> Use the same C preprocessor expressions to define FE_RMODE_MASK and
> __RISCV_HARD_FLOAT.
>
> The problem was noticed on GCC 10 which does not define __riscv_f.
> ---
> newlib/libc/machine/riscv/sys/fenv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/machine/riscv/sys/fenv.h
> b/newlib/libc/machine/riscv/sys/fenv.h
> index 1d577d527b..98387d2205 100644
> --- a/newlib/libc/machine/riscv/sys/fenv.h
> +++ b/newlib/libc/machine/riscv/sys/fenv.h
> @@ -14,7 +14,7 @@
>
> #include <stddef.h>
>
> -#if defined(__riscv_f) || defined(__riscv_zfinx)
> +#if defined(__riscv_flen) || defined(__riscv_zfinx)
>
> /* Per "The RISC-V Instruction Set Manual: Volume I: User-Level ISA:
> * Version 2.1", Section 8.2, "Floating-Point Control and Status
> --
> 2.35.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12 15:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 10:06 [PATCH] riscv: Fix fenv.h support Sebastian Huber
2023-10-12 14:36 ` Kito Cheng
2023-10-12 15:07 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).